You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Patrick Wendell <pw...@gmail.com> on 2012/07/11 02:53:18 UTC
Review Request: FLUME-1358: Add a regex-based filtering interceptor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5898/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Adding a regex-based filtering interceptor
This addresses bug FLUME-1358.
https://issues.apache.org/jira/browse/FLUME-1358
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java 0c112d0
flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java PRE-CREATION
Diff: https://reviews.apache.org/r/5898/diff/
Testing
-------
Unit tests are included
Thanks,
Patrick Wendell
Re: Review Request: FLUME-1358: Add a regex-based filtering interceptor
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5898/#review9052
-----------------------------------------------------------
Hi Patrik,
your code changes seems good to me. Could you also add new section into user guide with your new interceptor?
Jarcec
- Jarek Cecho
On July 11, 2012, 12:53 a.m., Patrick Wendell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5898/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 12:53 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Adding a regex-based filtering interceptor
>
>
> This addresses bug FLUME-1358.
> https://issues.apache.org/jira/browse/FLUME-1358
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java 0c112d0
> flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5898/diff/
>
>
> Testing
> -------
>
> Unit tests are included
>
>
> Thanks,
>
> Patrick Wendell
>
>
Re: Review Request: FLUME-1358: Add a regex-based filtering interceptor
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5898/#review9386
-----------------------------------------------------------
Ship it!
Hi Patrik,
you changes looks good to me. I'll commit them shortly.
Jarcec
- Jarek Cecho
On July 22, 2012, 8:21 p.m., Patrick Wendell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5898/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 8:21 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Adding a regex-based filtering interceptor
>
>
> This addresses bug FLUME-1358.
> https://issues.apache.org/jira/browse/FLUME-1358
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java 0c112d0
> flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst 7967d7c
>
> Diff: https://reviews.apache.org/r/5898/diff/
>
>
> Testing
> -------
>
> Unit tests are included
>
>
> Thanks,
>
> Patrick Wendell
>
>
Re: Review Request: FLUME-1358: Add a regex-based filtering interceptor
Posted by Patrick Wendell <pw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5898/
-----------------------------------------------------------
(Updated July 22, 2012, 8:21 p.m.)
Review request for Flume.
Changes
-------
Responding to Jarek's review with some minor documentation changes.
Description
-------
Adding a regex-based filtering interceptor
This addresses bug FLUME-1358.
https://issues.apache.org/jira/browse/FLUME-1358
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java 0c112d0
flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java PRE-CREATION
flume-ng-doc/sphinx/FlumeUserGuide.rst 7967d7c
Diff: https://reviews.apache.org/r/5898/diff/
Testing
-------
Unit tests are included
Thanks,
Patrick Wendell
Re: Review Request: FLUME-1358: Add a regex-based filtering interceptor
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5898/#review9277
-----------------------------------------------------------
Hi Patrick,
thank you very much for your time and effort. Code and tests seems good to me, I just have few notes to UserGuide changes:
flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5898/#comment19886>
Tilda characters ("~") are not below entire headline which results in compilation error:
System Message: WARNING/2 (/home/jarcec/projects/apache/flume/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1737)
Title underline too short.
flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5898/#comment19887>
Could you put "type" property in bold like **type**.
Jarcec
- Jarek Cecho
On July 19, 2012, 2:54 a.m., Patrick Wendell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5898/
> -----------------------------------------------------------
>
> (Updated July 19, 2012, 2:54 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Adding a regex-based filtering interceptor
>
>
> This addresses bug FLUME-1358.
> https://issues.apache.org/jira/browse/FLUME-1358
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java 0c112d0
> flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst 7967d7c
>
> Diff: https://reviews.apache.org/r/5898/diff/
>
>
> Testing
> -------
>
> Unit tests are included
>
>
> Thanks,
>
> Patrick Wendell
>
>
Re: Review Request: FLUME-1358: Add a regex-based filtering interceptor
Posted by Patrick Wendell <pw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5898/
-----------------------------------------------------------
(Updated July 19, 2012, 2:54 a.m.)
Review request for Flume.
Changes
-------
fixing small whitespace problem - this is still ready for review thanks.
Description
-------
Adding a regex-based filtering interceptor
This addresses bug FLUME-1358.
https://issues.apache.org/jira/browse/FLUME-1358
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java 0c112d0
flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java PRE-CREATION
flume-ng-doc/sphinx/FlumeUserGuide.rst 7967d7c
Diff: https://reviews.apache.org/r/5898/diff/
Testing
-------
Unit tests are included
Thanks,
Patrick Wendell
Re: Review Request: FLUME-1358: Add a regex-based filtering interceptor
Posted by Patrick Wendell <pw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5898/
-----------------------------------------------------------
(Updated July 12, 2012, 9:12 p.m.)
Review request for Flume.
Changes
-------
This patch changes the configuration a bit to make it more explicit and less confusing.
It also adds documentation to the user guide.
Description
-------
Adding a regex-based filtering interceptor
This addresses bug FLUME-1358.
https://issues.apache.org/jira/browse/FLUME-1358
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java 0c112d0
flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java PRE-CREATION
flume-ng-doc/sphinx/FlumeUserGuide.rst 7967d7c
Diff: https://reviews.apache.org/r/5898/diff/
Testing
-------
Unit tests are included
Thanks,
Patrick Wendell