You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/05/10 16:59:47 UTC

[GitHub] [spark] hvanhovell commented on a diff in pull request #41123: [SPARK-43428][FOLLOW-UP] Utils and JSON Utils refactoring

hvanhovell commented on code in PR #41123:
URL: https://github.com/apache/spark/pull/41123#discussion_r1190183443


##########
common/utils/src/main/scala/org/apache/spark/util/JsonUtils.scala:
##########
@@ -39,3 +39,5 @@ private[spark] object JsonUtils {
     new String(baos.toByteArray, StandardCharsets.UTF_8)
   }
 }
+

Review Comment:
   `ByteArrayOutputStream` does not really need to be closed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org