[GitHub] [incubator-doris] morningman commented on a change in pull request #4006: [Feature] Support InPredicate in delete statement

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4006:
URL: https://github.com/apache/incubator-doris/pull/4006#discussion_r463960031



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1192,4 +1191,11 @@
      */
     @ConfField(mutable = true, masterOnly = false)
     public static int cache_result_max_row_count = 3000;
+    
+    /**
+     * Used to limit element num of InPredicate in delete statement.
+     */
+    @ConfField(mutable = true, masterOnly = true)

Review comment:
       ```suggestion
       @ConfField(mutable = true)
   ```
   This is not a "master only" config.

##########
File path: be/src/olap/delete_handler.cpp
##########
@@ -66,9 +67,22 @@ OLAPStatus DeleteConditionHandler::generate_delete_predicate(
 
     // 存储删除条件
     for (const TCondition& condition : conditions) {
-        string condition_str = construct_sub_predicates(condition);
-        del_pred->add_sub_predicates(condition_str);
-        LOG(INFO) << "store one sub-delete condition. condition=" << condition_str;
+        if (condition.condition_values.size() > 1) {

Review comment:
       I think it's better to check the `condition.condition_op` to see if this condition is InPredicate, not by the size of `condition.condition_values`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org