You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/10 00:33:07 UTC

[GitHub] codecov-io edited a comment on issue #6523: Improving Filter Box

codecov-io edited a comment on issue #6523: Improving Filter Box
URL: https://github.com/apache/incubator-superset/pull/6523#issuecomment-446683914
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6523?src=pr&el=h1) Report
   > Merging [#6523](https://codecov.io/gh/apache/incubator-superset/pull/6523?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbf9586adfe0b971b35584f2622d750be8d57126?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `54.83%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6523/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6523?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6523      +/-   ##
   ==========================================
   + Coverage   56.25%   56.26%   +0.01%     
   ==========================================
     Files         518      519       +1     
     Lines       23006    23069      +63     
     Branches     2750     2756       +6     
   ==========================================
   + Hits        12941    12979      +38     
   - Misses       9654     9680      +26     
   + Partials      411      410       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6523?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et/assets/src/explore/components/controls/index.js](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvaW5kZXguanM=) | `100% <ø> (ø)` | :arrow_up: |
   | [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `8.47% <ø> (ø)` | :arrow_up: |
   | [superset/data/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS93b3JsZF9iYW5rLnB5) | `100% <ø> (ø)` | :arrow_up: |
   | [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQ29sbGVjdGlvbkNvbnRyb2wuanN4) | `22.58% <ø> (ø)` | :arrow_up: |
   | [...ets/src/visualizations/FilterBox/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | :arrow_up: |
   | [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.74% <0%> (-0.35%)` | :arrow_down: |
   | [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `0% <0%> (ø)` | :arrow_up: |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRmlsdGVyQm94SXRlbUNvbnRyb2wuanN4) | `62.85% <62.85%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.24% <85%> (-0.03%)` | :arrow_down: |
   | [superset/assets/src/components/FormRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0Zvcm1Sb3cuanN4) | `92.3% <92.3%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/6523/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6523?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6523?src=pr&el=footer). Last update [fbf9586...88c6223](https://codecov.io/gh/apache/incubator-superset/pull/6523?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org