You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/04/14 23:11:54 UTC

[GitHub] sagelywizard opened a new pull request #477: Add LRU for view groups

sagelywizard opened a new pull request #477: Add LRU for view groups
URL: https://github.com/apache/couchdb/pull/477
 
 
   <!-- Thank you for your contribution!
        
        Please file this form by replacing markdown commentary
        tags with the text. If section needs in no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model 
        of code collaboration. Positive feedback provides by +1 from committers
        while negative by -1. The -1 also means veto and need to be addressed
        to find the consensus. Once there are no objections, PR could be merged.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info -->
   
   ## Overview
   
   This PR changes how CouchDB manages view indexes. Specifically, it 1) adds an LRU cache to couch_index_server for view groups 2) causes idle view groups to close if more than a configurable soft maximum number of indexes are open and 3) adds additional bookkeeping for couch_index_server to track if a view index is eligible for closing. The PR also has a few other changes in CouchDB for bits of code which assume view groups are never closed.
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   This is primarily a performance improvement and shouldn't affect the API. This PR includes eunit tests, which can be run with `make check`.
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users 
        could notice? -->
   
   ## JIRA issue number
   
   COUCHDB-3377
   <!-- If this is a significant change, please file a JIRA issue at:
        https://issues.apache.org/jira/browse/COUCHDB
        and include the number here and in commit message(s)  -->
   
   ## Related Pull Requests
   
   None
   <!-- If your changes affects on multiple components in different 
        repositories please list here links to those pull requests.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] I will not forget to update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
         with the correct commit hash once this PR get merged.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services