You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Eric Biederman <eb...@xmission.com> on 2013/10/22 09:11:09 UTC
Review Request 14825: cgroup_isolator: Report the actual amount of memory
used
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Repository: mesos-git
Description
-------
cgroup_isolator: Report the actual amount of memory used
Report the number of bytes used by the memory cgroup, and stop
reporting memory with no file backed pages taken into account.
Diffs
-----
src/slave/cgroups_isolator.cpp fc36f1f
Diff: https://reviews.apache.org/r/14825/diff/
Testing
-------
Verified that memory.stat:rss is the wrong value.
Verified that memory.usage_in_bytes is the correct value.
make check
Verified the code is idiomatic and trivial.
Thanks,
Eric Biederman
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27286
-----------------------------------------------------------
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment53121>
drop the !
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment53122>
drop the !
- Ian Downes
On Oct. 22, 2013, 7:11 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 7:11 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 22, 2013, 10:44 p.m., Ben Mahler wrote:
> > We can also expose this as a new statistic "mem_usage_bytes", leaving "mem_rss_bytes" unchanged. Do you think differentiating the two would be beneficial or is rss not measured correctly?
+1
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27340
-----------------------------------------------------------
On Oct. 22, 2013, 8:07 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 8:07 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Eric Biederman <eb...@xmission.com>.
> On Oct. 22, 2013, 10:44 p.m., Ben Mahler wrote:
> > We can also expose this as a new statistic "mem_usage_bytes", leaving "mem_rss_bytes" unchanged. Do you think differentiating the two would be beneficial or is rss not measured correctly?
>
> Vinod Kone wrote:
> +1
RSS is an abbreviation of resident set size, which is just memory management speak for how much memory something is using. Which is exactly the memory usage in bytes.
memory.stat:rss measures something completely different. For a trivial application like bash it will deviate from the resident set size by as much as 50% of the memory mapped and in use by the process. memory.stat:rss is even worse because it does not even total up the entire memory cgroup. So memory.stat:rss does not seem to be a value we want to use for anything.
Furthermore mem_rss_bytes is the multiplatform generic value and as such we should populate it with the most reasonable value we can find of the rss. Allowing for some code that works across Mesos on different OS's.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27340
-----------------------------------------------------------
On Oct. 22, 2013, 8:07 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 8:07 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27340
-----------------------------------------------------------
Ship it!
We can also expose this as a new statistic "mem_usage_bytes", leaving "mem_rss_bytes" unchanged. Do you think differentiating the two would be beneficial or is rss not measured correctly?
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment53181>
kill the tab character
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment53182>
newline
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment53183>
newline
- Ben Mahler
On Oct. 22, 2013, 8:07 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 8:07 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review28215
-----------------------------------------------------------
Thanks Eric! I've fixed up the comments and submitted this for you, can you mark it submitted?
- Ben Mahler
On Oct. 29, 2013, 6:32 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:32 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27973
-----------------------------------------------------------
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment54424>
s/decode/parse/ ?
- Ian Downes
On Oct. 29, 2013, 6:32 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:32 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Eric Biederman <eb...@xmission.com>.
> On Oct. 29, 2013, 10:16 p.m., Ben Mahler wrote:
> > src/slave/cgroups_isolator.cpp, line 783
> > <https://reviews.apache.org/r/14825/diff/3/?file=372966#file372966line783>
> >
> > Thanks for clarifying!
> >
> > For posterity, can you add a little note in the code explaining why we're avoiding 'rss' from the memory.stat file?
There is a Jira where it is explained.
Further the next change that adds additional statistics makes it clear what the rss field actually measures.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27737
-----------------------------------------------------------
On Oct. 29, 2013, 6:32 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:32 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27737
-----------------------------------------------------------
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment53878>
Thanks for clarifying!
For posterity, can you add a little note in the code explaining why we're avoiding 'rss' from the memory.stat file?
- Ben Mahler
On Oct. 29, 2013, 6:32 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:32 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27974
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On Oct. 29, 2013, 6:32 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:32 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Eric Biederman <eb...@xmission.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/
-----------------------------------------------------------
(Updated Oct. 29, 2013, 6:32 a.m.)
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Changes
-------
modified to use cgroups::memory::usage_in_bytes
Bugs: Mesos-758
https://issues.apache.org/jira/browse/Mesos-758
Repository: mesos-git
Description
-------
cgroup_isolator: Report the actual amount of memory used
Report the number of bytes used by the memory cgroup, and stop
reporting memory with no file backed pages taken into account.
Diffs (updated)
-----
src/slave/cgroups_isolator.cpp fc36f1f
Diff: https://reviews.apache.org/r/14825/diff/
Testing
-------
Verified that memory.stat:rss is the wrong value.
Verified that memory.usage_in_bytes is the correct value.
make check
Verified the code is idiomatic and trivial.
Thanks,
Eric Biederman
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27352
-----------------------------------------------------------
Ship it!
modulo benm's comments.
- Vinod Kone
On Oct. 22, 2013, 8:07 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 8:07 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Eric Biederman <eb...@xmission.com>.
> On Oct. 23, 2013, 1:04 a.m., Vinod Kone wrote:
> > src/slave/cgroups_isolator.cpp, lines 774-775
> > <https://reviews.apache.org/r/14825/diff/2/?file=369123#file369123line774>
> >
> > Can you actually just use cgroups::memory::usage_in_bytes() ?
> >
> >
> > Also, we should probably just export everything in memory.stat file. If you don't want to do it in this review, please add a TODO.
cgroups::memory::usage_in_bytes() sure.
As for the rest I will send an additonal patch.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27353
-----------------------------------------------------------
On Oct. 29, 2013, 6:32 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:32 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/#review27353
-----------------------------------------------------------
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/14825/#comment53217>
Can you actually just use cgroups::memory::usage_in_bytes() ?
Also, we should probably just export everything in memory.stat file. If you don't want to do it in this review, please add a TODO.
- Vinod Kone
On Oct. 22, 2013, 8:07 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14825/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 8:07 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: Mesos-758
> https://issues.apache.org/jira/browse/Mesos-758
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cgroup_isolator: Report the actual amount of memory used
>
> Report the number of bytes used by the memory cgroup, and stop
> reporting memory with no file backed pages taken into account.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp fc36f1f
>
> Diff: https://reviews.apache.org/r/14825/diff/
>
>
> Testing
> -------
>
> Verified that memory.stat:rss is the wrong value.
> Verified that memory.usage_in_bytes is the correct value.
>
> make check
>
> Verified the code is idiomatic and trivial.
>
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Eric Biederman <eb...@xmission.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/
-----------------------------------------------------------
(Updated Oct. 22, 2013, 8:07 a.m.)
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Changes
-------
Doh! Removed the incorrect !.
Bugs: Mesos-758
https://issues.apache.org/jira/browse/Mesos-758
Repository: mesos-git
Description
-------
cgroup_isolator: Report the actual amount of memory used
Report the number of bytes used by the memory cgroup, and stop
reporting memory with no file backed pages taken into account.
Diffs (updated)
-----
src/slave/cgroups_isolator.cpp fc36f1f
Diff: https://reviews.apache.org/r/14825/diff/
Testing
-------
Verified that memory.stat:rss is the wrong value.
Verified that memory.usage_in_bytes is the correct value.
make check
Verified the code is idiomatic and trivial.
Thanks,
Eric Biederman
Re: Review Request 14825: cgroup_isolator: Report the actual amount of
memory used
Posted by Eric Biederman <eb...@xmission.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14825/
-----------------------------------------------------------
(Updated Oct. 22, 2013, 7:11 a.m.)
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs: Mesos-758
https://issues.apache.org/jira/browse/Mesos-758
Repository: mesos-git
Description
-------
cgroup_isolator: Report the actual amount of memory used
Report the number of bytes used by the memory cgroup, and stop
reporting memory with no file backed pages taken into account.
Diffs
-----
src/slave/cgroups_isolator.cpp fc36f1f
Diff: https://reviews.apache.org/r/14825/diff/
Testing
-------
Verified that memory.stat:rss is the wrong value.
Verified that memory.usage_in_bytes is the correct value.
make check
Verified the code is idiomatic and trivial.
Thanks,
Eric Biederman