You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/07/28 00:30:48 UTC
[GitHub] [ozone] duongnguyen0 opened a new pull request, #3633: HDDS-7059. S3G should not call lookup twice for Get Object
duongnguyen0 opened a new pull request, #3633:
URL: https://github.com/apache/ozone/pull/3633
## What changes were proposed in this pull request?
Remove the additional lookupKeys calls in getObject API.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7059
## How was this patch tested?
Unit, rotbot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] duongnguyen0 commented on pull request #3633: HDDS-7059. S3G should not call lookup twice for Get Object
Posted by GitBox <gi...@apache.org>.
duongnguyen0 commented on PR #3633:
URL: https://github.com/apache/ozone/pull/3633#issuecomment-1198322805
Thanks for looking at this and for the suggestion which fixes the failing integration tests, @adoroszlai.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime merged pull request #3633: HDDS-7059. S3G should not call lookup twice for Get Object
Posted by GitBox <gi...@apache.org>.
kerneltime merged PR #3633:
URL: https://github.com/apache/ozone/pull/3633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3633: HDDS-7059. S3G should not call lookup twice for Get Object
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3633:
URL: https://github.com/apache/ozone/pull/3633#discussion_r931863681
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKeyDetails.java:
##########
@@ -95,4 +102,13 @@ public FileEncryptionInfo getFileEncryptionInfo() {
public void setOzoneKeyLocations(List<OzoneKeyLocation> ozoneKeyLocations) {
this.ozoneKeyLocations = ozoneKeyLocations;
}
+
+ /**
+ * Get OzoneInputStream to read the content of the key.
+ * @return OzoneInputStream
+ * @throws IOException
+ */
+ public OzoneInputStream getContent() throws IOException {
Review Comment:
`OzoneKeyDetails` is converted to JSON by `ozone sh key info`. The `getContent()` method should be excluded from the conversion, because we don't want the binary content to be shown along with metadata.
```suggestion
@JsonIgnore
public OzoneInputStream getContent() throws IOException {
```
This prevents:
```
No serializer found for ... org.apache.hadoop.ozone.client.OzoneKeyDetails["content"]->org.apache.hadoop.ozone.client.io.OzoneInputStream["inputStream"]->...
```
https://github.com/apache/ozone/runs/7554046528?check_suite_focus=true#step:5:253
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKeyDetails.java:
##########
@@ -21,7 +21,10 @@
import org.apache.hadoop.fs.FileEncryptionInfo;
Review Comment:
Import for `@JsonIgnore`:
```suggestion
import com.fasterxml.jackson.annotation.JsonIgnore;
import org.apache.hadoop.fs.FileEncryptionInfo;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3633: HDDS-7059. S3G should not call lookup twice for Get Object
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3633:
URL: https://github.com/apache/ozone/pull/3633#issuecomment-1198671517
Thank you @duongnguyen0 for the quick turn around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org