You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/14 13:22:39 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
xiaoxiang781216 opened a new pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666
## Summary
simplify the code logic and reduce memory a little bit
## Impact
Internal interface change
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666#issuecomment-944906477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666#issuecomment-945058336
Ok, I found the problem, @masayuki2009 could you try https://github.com/apache/incubator-nuttx/pull/4676?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666#issuecomment-944869723
@gustavonihei could you merge it if no more issue, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666#issuecomment-944906477
@xiaoxiang781216
I noticed that the ostest crashed with esp32-devkitc:smp (QEMU), maix-bit:smp (QEMU), and sim:smp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666#issuecomment-945050035
> @xiaoxiang781216
>
> > I noticed that the ostest crashed with esp32-devkitc:smp (QEMU), maix-bit:smp (QEMU), and sim:smp.
>
> The ostest with spresense:smp and sabre-quad:smp work but the above configurations do not work.
It's strange that this patch could affect SMP on some targets.
> I think we should revert this PR until the root cause of the issue is resolved.
>
> What do you think?
I will investigate the problem today, we can revert it if the root cause can't find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4666: sched: Remove pidhash_s and move ticks to tcb_s
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4666:
URL: https://github.com/apache/incubator-nuttx/pull/4666#issuecomment-945073123
> Ok, I found the problem, @masayuki2009 could you try #4676?
@xiaoxiang781216
Thanks, the PR fixes the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org