You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/25 11:29:21 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #25939: Fix placeholders in `TrinoHook`, `PrestoHook`, `SqliteHook`

uranusjr commented on code in PR #25939:
URL: https://github.com/apache/airflow/pull/25939#discussion_r954850614


##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -109,6 +109,8 @@ class DbApiHook(BaseForDbApiHook):
     connector = None  # type: Optional[ConnectorProtocol]
     # Override with db-specific query to check connection
     _test_connection_sql = "select 1"
+    # Override with the db-specific value used for placeholders
+    placeholder = "%s"  # type: str

Review Comment:
   ```suggestion
       placeholder: str = "%s"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org