You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dejan2609 (via GitHub)" <gi...@apache.org> on 2023/02/16 17:38:13 UTC

[GitHub] [kafka] dejan2609 opened a new pull request, #13263: KAFKA-14728: Gradle task 'spotlessScalaCheck' is moved out of Jenkinsfile

dejan2609 opened a new pull request, #13263:
URL: https://github.com/apache/kafka/pull/13263

   Blocks this PR: #13205
   
   Related JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-14728
   
   Rationale:
   - build works fine in trunk with Gradle 7.6 and spotless gradle plugin 6.13.0 for all currently used JDK versions (that is: JDK 8 / JDK 11 / JDK 17)
   - however, recent spotless gradle plugin versions (6.14.+) support only JDK 11+ versions: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26
   - given a fact that Kafka still needs to support JDK 8 builds (until Kafka version 4.0) it is reasonable to simply remove spotless checks out of Jenkinsfile (and re-introduce them when the time comes).
   
   For even more details see GitHub discussion here: https://github.com/apache/kafka/pull/13205#issuecomment-1431575644
   
   
   @ijuma feel free to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #13263: KAFKA-14728: Gradle task 'spotlessScalaCheck' is moved out of Jenkinsfile

Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13263:
URL: https://github.com/apache/kafka/pull/13263#issuecomment-1441825913

   @mjsax @vvcephei I'm going to merge this PR. If we find a way to support this tool without requiring Java 11, we can re-enable before Apache Kafka 4.0. If not, we can re-enable once we drop support for Java 8. @dejan2609 can you please file a JIRA for re-enabling this with target version 4.0 and set it as a blocker?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #13263: KAFKA-14728: Don't run 'spotlessScalaCheck' in CI

Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on PR #13263:
URL: https://github.com/apache/kafka/pull/13263#issuecomment-1442184497

   Thanks @ijuma for the heads up, that makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dejan2609 commented on pull request #13263: KAFKA-14728: Gradle task 'spotlessScalaCheck' is moved out of Jenkinsfile

Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #13263:
URL: https://github.com/apache/kafka/pull/13263#issuecomment-1433744998

   Only handfull of tests failed (those errors are obviosly unrelated to this small change).
   
   FYI @ijuma 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dejan2609 commented on pull request #13263: KAFKA-14728: Don't run 'spotlessScalaCheck' in CI

Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #13263:
URL: https://github.com/apache/kafka/pull/13263#issuecomment-1442530050

   @ijuma JIRA ticket created here: https://issues.apache.org/jira/browse/KAFKA-14749


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #13263: KAFKA-14728: Don't run 'spotlessScalaCheck' in CI

Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma merged PR #13263:
URL: https://github.com/apache/kafka/pull/13263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #13263: KAFKA-14728: Don't run 'spotlessScalaCheck' in CI

Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13263:
URL: https://github.com/apache/kafka/pull/13263#issuecomment-1445906790

   @guozhangwang Note that we found a way to re-enable this when running with Java 11 or newer, see #13311.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org