You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:37:40 UTC
[GitHub] [shardingsphere] Rohitpandey357 opened a new issue, #19532: Splitting test method with multiple assert statements into multiple methods
Rohitpandey357 opened a new issue, #19532:
URL: https://github.com/apache/shardingsphere/issues/19532
Hey @terrymanu , As discussed in #19493 , should I go ahead and split the assertIsGenerateSQLToken() method into multiple methods in the following test files?
Below are the files which could be refactored :
- [ShardingInsertValuesTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ShardingInsertValuesTokenGeneratorTest.java)
- [RowCountTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/RowCountTokenGeneratorTest.java)
- [OrderByTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/OrderByTokenGeneratorTest.java)
- [IndexTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/IndexTokenGeneratorTest.java)
- [DistinctProjectionPrefixTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/DistinctProjectionPrefixTokenGeneratorTest.java)
- [CursorTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/CursorTokenGeneratorTest.java)
- [ConstraintTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ConstraintTokenGeneratorTest.java)
- [ConstraintTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ConstraintTokenGeneratorTest.java)
Right now, there are multiple assert statements in the assertIsGenerateSQLToken() which can be broken down into multiple methods like the following test file -> [ShardingRemoveTokenGeneratorTest.java](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ShardingRemoveTokenGeneratorTest.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] closed issue #19532: Splitting test method with multiple assert statements into multiple methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #19532: Splitting test method with multiple assert statements into multiple methods
URL: https://github.com/apache/shardingsphere/issues/19532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #19532: Splitting test method with multiple assert statements into multiple methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #19532:
URL: https://github.com/apache/shardingsphere/issues/19532#issuecomment-1272349236
Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org