You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by jasontedor <gi...@git.apache.org> on 2018/05/18 17:37:16 UTC
[GitHub] httpcomponents-core pull request #64: Add remote address to connect exceptio...
GitHub user jasontedor opened a pull request:
https://github.com/apache/httpcomponents-core/pull/64
Add remote address to connect exception
Today when timing out a connection the exception message is not populated. This is not helpful for end users. This commit adds an exception message that indicates the cause of the connect exception is a timeout to the remote address.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasontedor/httpcomponents-core add-remote-address-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcomponents-core/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 1193fcecba4ff44c89b2f04762327fb17fe329b1
Author: Jason Tedor <ja...@...>
Date: 2018-05-18T17:34:48Z
Add remote address to connect exception
Today when timing out a connection the exception message is not
populated. This is not helpful for end users. This commit adds an
exception message that indicates the cause of the connect exception is a
timeout to the remote address.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-core issue #64: Add remote address to connect exception
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/64
I committed this PR with some minor changes to the branch 4.4.x. Please verify and close.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-core pull request #64: Add remote address to connect exceptio...
Posted by jasontedor <gi...@git.apache.org>.
Github user jasontedor closed the pull request at:
https://github.com/apache/httpcomponents-core/pull/64
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-core issue #64: Add remote address to connect exception
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/64
@jasontedor @garydgregory Works for me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-core issue #64: Add remote address to connect exception
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/64
Sounds reasonable to me. @ok2c ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-core issue #64: Add remote address to connect exception
Posted by jasontedor <gi...@git.apache.org>.
Github user jasontedor commented on the issue:
https://github.com/apache/httpcomponents-core/pull/64
Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org