You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/15 03:26:00 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view

jinxing64 commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view
URL: https://github.com/apache/calcite/pull/1704#discussion_r366681134
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java
 ##########
 @@ -173,6 +173,23 @@ public RexNode get(int index) {
         .collect(Collectors.toList());
   }
 
+  /**
+   * Construct expression list of Project by the given fields of the input.
+   */
 
 Review comment:
   Seems this method only converts the row type for `RexInputRef`, why this is taken into consideration specially ?
   BTW I can pass the test you provided in MaterializationTest.java without this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services