[GitHub] [nifi] mattyb149 commented on a change in pull request #4147: NIFI-7260: Fix error handling and re-evaluate Module Directory property on changed for scripted controller services

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #4147: NIFI-7260: Fix error handling and re-evaluate Module Directory property on changed for scripted controller services
URL: https://github.com/apache/nifi/pull/4147#discussion_r393826015
 
 

 ##########
 File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/record/script/AbstractScriptedRecordFactory.java
 ##########
 @@ -42,9 +42,13 @@ public void setup() {
 
         if (scriptNeedsReload.get() || recordFactory.get() == null) {
             if (ScriptingComponentHelper.isFile(scriptingComponentHelper.getScriptPath())) {
-                reloadScriptFile(scriptingComponentHelper.getScriptPath());
+                if (!reloadScriptFile(scriptingComponentHelper.getScriptPath())) {
 
 Review comment:
   The exception was supposed to prevent the CS from enabling, Andy pointed out the same issue. I thought I'd tested that but apparently did not, will take a closer look

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services