[jira] [Commented] (SOLR-8455) Minor improvements to RecoveryStrategy

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069563#comment-15069563 ] 

ASF subversion and git services commented on SOLR-8455:
-------------------------------------------------------

Commit 1721531 from [~shaie] in branch 'dev/trunk'
[ https://svn.apache.org/r1721531 ]

SOLR-8455: Improve RecoveryStrategy logging and fix interval-between-recovery-attempts

> Minor improvements to RecoveryStrategy
> --------------------------------------
>
>                 Key: SOLR-8455
>                 URL: https://issues.apache.org/jira/browse/SOLR-8455
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 5.5, Trunk
>
>         Attachments: SOLR-8455.patch, SOLR-8455.patch
>
>
> This issue addresses multiple minor improvements to {{RecoveryStrategy}}:
> * Logging improvements: proper use of Logger interface, improve log messages.
> * Consolidated a debug block into a method and reuse.
> * Get rid of unused and deprecated code.
> In addition, the code over-slept between recovery attempts. The inline comment suggested that the intention was to sleep between 1 second to 1 minute, while implement an exponential sleep interval strategy. However in practice the code sleeps in intervals of 5 seconds and up to 5 minutes. So I fixed the code to sleep at interval of 5 seconds (checking if it was closed in between sleep attempts) and up to 1 minute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org