[GitHub] chetanmeh edited a comment on issue #4165: Update to Kamon 1.1.3 from 0.6 series

[GitBox <gi...@apache.org>]

chetanmeh edited a comment on issue #4165: Update to Kamon 1.1.3 from 0.6 series
URL: https://github.com/apache/incubator-openwhisk/pull/4165#issuecomment-446138192
 
 
   Seems like Kamon has changed the [metric naming convention](https://github.com/kamon-io/kamon-datadog/pull/20#issuecomment-391419144). Earlier it used to include the metric type/category as part of name like `openwhisk-statsd.invoker0.counter.database_cacheMiss_count` and now its dropping that which lead to error in our case like 
   
   ```
   [2018-12-11T15:05:44.284Z] [ERROR] Cannot define metric [database_getDocument_error] as a [Counter], it is already defined as [Histogram] 
   java.lang.RuntimeException: Cannot define metric [database_getDocument_error] as a [Counter], it is already defined as [Histogram] 
   	at scala.sys.package$.error(package.scala:26)
   	at kamon.metric.MetricRegistry.lookupMetric(MetricRegistry.scala:83)
   	at kamon.metric.MetricRegistry.counter(MetricRegistry.scala:48)
   	at kamon.Kamon$.counter(Kamon.scala:82)
   	at kamon.metric.MetricLookup.counter(MetricLookup.scala:41)
   	at kamon.metric.MetricLookup.counter$(MetricLookup.scala:40)
   	at kamon.Kamon$.counter(Kamon.scala:32)
   	at org.apache.openwhisk.common.MetricEmitter$.emitCounterMetric(Logging.scala:222)
   ```
   
   So we would probably need to do that on our side 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services