You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/23 17:16:59 UTC

[GitHub] rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split
URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176805604
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/LocalZooKeeperCacheService.java
 ##########
 @@ -105,6 +108,38 @@ public LocalPolicies deserialize(String path, byte[] content) throws Exception {
 
                 return future;
             }
+
+            @Override
+            public CompletableFuture<Optional<Entry<LocalPolicies, Stat>>> getWithStatAsync(String path) {
 
 Review comment:
   should we delete `getAsync(String path)` as it has duplicate logic and it is being used by bundle split only?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services