You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/20 17:45:48 UTC
[GitHub] [camel] lmolkova opened a new pull request, #8934: Tracing: fix flaky test and add scope schecks
lmolkova opened a new pull request, #8934:
URL: https://github.com/apache/camel/pull/8934
Follow up for #8713 and #8911.
I was able to repro failures locally and with this change, they are no longer reproducible (tried on 1000 iterations).
Fixes flaky `CurrentSpanTest.testContextDoesNotLeak` test. There are severalproblems:
1. We can't guarantee that `ExchangeAsyncProcessingStartedEvent` is fired once and only if span was created
2. We can't guarantee that span ends on the same thread it was started, i.e. scope is closed on the same thread
3. Due to concurrency in async scenarios we can call close on scope two times
Unfortunately, OTel scope closing works differently than I thought - https://github.com/open-telemetry/opentelemetry-java/issues/5055
While the solution on OTel side is evaluated, I suggest guarding scope closing.
This PR also adds logging in case there is more flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #8934: Tracing: fix flaky test and add scope schecks
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #8934:
URL: https://github.com/apache/camel/pull/8934#discussion_r1053587419
##########
components/camel-opentelemetry/src/test/resources/log4j2.properties:
##########
@@ -24,6 +24,6 @@ appender.out.name=out
appender.out.layout.type=PatternLayout
appender.out.layout.pattern=%d [%-15.15t] %-5p %-30.30c{1} - %m%n
logger.opentelemetry.name=org.apache.camel.opentelemetry
-logger.opentelemetry.level=INFO
+logger.opentelemetry.level=DEBUG
Review Comment:
I think should be INFO again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8934: Tracing: fix flaky test and add scope checks before closing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8934:
URL: https://github.com/apache/camel/pull/8934#issuecomment-1360400900
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 8 | 8 | 0 | 9 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lmolkova commented on a diff in pull request #8934: Tracing: fix flaky test and add scope schecks
Posted by GitBox <gi...@apache.org>.
lmolkova commented on code in PR #8934:
URL: https://github.com/apache/camel/pull/8934#discussion_r1053589848
##########
components/camel-opentelemetry/src/test/resources/log4j2.properties:
##########
@@ -24,6 +24,6 @@ appender.out.name=out
appender.out.layout.type=PatternLayout
appender.out.layout.pattern=%d [%-15.15t] %-5p %-30.30c{1} - %m%n
logger.opentelemetry.name=org.apache.camel.opentelemetry
-logger.opentelemetry.level=INFO
+logger.opentelemetry.level=DEBUG
Review Comment:
sure, let's just see if tests pass in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8934: Tracing: fix flaky test and add scope schecks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8934:
URL: https://github.com/apache/camel/pull/8934#issuecomment-1359897539
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8934: Tracing: fix flaky test and add scope checks before closing
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8934:
URL: https://github.com/apache/camel/pull/8934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8934: Tracing: fix flaky test and add scope checks before closing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8934:
URL: https://github.com/apache/camel/pull/8934#issuecomment-1359963898
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 0 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8934: Tracing: fix flaky test and add scope checks before closing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8934:
URL: https://github.com/apache/camel/pull/8934#issuecomment-1360100312
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 8 | 8 | 1 | 8 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org