You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2011/03/09 16:55:53 UTC
QPID-3121: release branch broken on windows
The changes committed to the release branch for QPID-3121 (Cluster
management inconsistency when using persistent store) broke the windows
build.
I committed the trivial fix to the trunk for this already, which only
affects linking and has no logic changes in it at all and iths adds no
risk to the already approved changes
(http://svn.apache.org/viewvc?view=revision&revision=1079313).
I believe the same change needs to be applied to the release branch (or
else the changes that broke the built would need to be backed out).
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
RE: QPID-3121: release branch broken on windows
Posted by Steve Huston <sh...@riverace.com>.
FWIW, I'd like this change to be merged to the release branch.
-Steve
> -----Original Message-----
> From: Gordon Sim [mailto:gsim@redhat.com]
> Sent: Wednesday, March 09, 2011 10:56 AM
> To: dev@qpid.apache.org
> Subject: QPID-3121: release branch broken on windows
>
>
> The changes committed to the release branch for QPID-3121 (Cluster
> management inconsistency when using persistent store) broke
> the windows
> build.
>
> I committed the trivial fix to the trunk for this already, which only
> affects linking and has no logic changes in it at all and
> iths adds no
> risk to the already approved changes
> (http://svn.apache.org/viewvc?view=revision&revision=1079313).
>
> I believe the same change needs to be applied to the release
> branch (or
> else the changes that broke the built would need to be backed out).
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: QPID-3121: release branch broken on windows
Posted by Gordon Sim <gs...@redhat.com>.
On 03/09/2011 04:53 PM, Justin Ross wrote:
> Yes, approved.
Thanks! Merged as r1079892.
> On Wed, 9 Mar 2011, Gordon Sim wrote:
>
>> On 03/09/2011 04:28 PM, Chuck Rolke wrote:
>>> r1079313 is the correct patch to fix the 0.10 build issue which I
>>> just proved in a local build. I approve.
>>
>> Justin, ok with you?
>>
>>> ----- Original Message -----
>>>> From: "Gordon Sim"<gs...@redhat.com>
>>>> To: dev@qpid.apache.org
>>>> Sent: Wednesday, March 9, 2011 10:55:53 AM
>>>> Subject: QPID-3121: release branch broken on windows
>>>> The changes committed to the release branch for QPID-3121 (Cluster
>>>> management inconsistency when using persistent store) broke the
>>>> windows
>>>> build.
>>>>
>>>> I committed the trivial fix to the trunk for this already, which only
>>>> affects linking and has no logic changes in it at all and iths adds no
>>>> risk to the already approved changes
>>>> (http://svn.apache.org/viewvc?view=revision&revision=1079313).
>>>>
>>>> I believe the same change needs to be applied to the release branch
>>>> (or
>>>> else the changes that broke the built would need to be backed out).
>>>>
>>>> ---------------------------------------------------------------------
>>>> Apache Qpid - AMQP Messaging Implementation
>>>> Project: http://qpid.apache.org
>>>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> Apache Qpid - AMQP Messaging Implementation
>>> Project: http://qpid.apache.org
>>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: QPID-3121: release branch broken on windows
Posted by Justin Ross <jr...@redhat.com>.
Yes, approved.
On Wed, 9 Mar 2011, Gordon Sim wrote:
> On 03/09/2011 04:28 PM, Chuck Rolke wrote:
>> r1079313 is the correct patch to fix the 0.10 build issue which I just
>> proved in a local build. I approve.
>
> Justin, ok with you?
>
>> ----- Original Message -----
>>> From: "Gordon Sim"<gs...@redhat.com>
>>> To: dev@qpid.apache.org
>>> Sent: Wednesday, March 9, 2011 10:55:53 AM
>>> Subject: QPID-3121: release branch broken on windows
>>> The changes committed to the release branch for QPID-3121 (Cluster
>>> management inconsistency when using persistent store) broke the
>>> windows
>>> build.
>>>
>>> I committed the trivial fix to the trunk for this already, which only
>>> affects linking and has no logic changes in it at all and iths adds no
>>> risk to the already approved changes
>>> (http://svn.apache.org/viewvc?view=revision&revision=1079313).
>>>
>>> I believe the same change needs to be applied to the release branch
>>> (or
>>> else the changes that broke the built would need to be backed out).
>>>
>>> ---------------------------------------------------------------------
>>> Apache Qpid - AMQP Messaging Implementation
>>> Project: http://qpid.apache.org
>>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: QPID-3121: release branch broken on windows
Posted by Gordon Sim <gs...@redhat.com>.
On 03/09/2011 04:28 PM, Chuck Rolke wrote:
> r1079313 is the correct patch to fix the 0.10 build issue which I just proved in a local build. I approve.
Justin, ok with you?
> ----- Original Message -----
>> From: "Gordon Sim"<gs...@redhat.com>
>> To: dev@qpid.apache.org
>> Sent: Wednesday, March 9, 2011 10:55:53 AM
>> Subject: QPID-3121: release branch broken on windows
>> The changes committed to the release branch for QPID-3121 (Cluster
>> management inconsistency when using persistent store) broke the
>> windows
>> build.
>>
>> I committed the trivial fix to the trunk for this already, which only
>> affects linking and has no logic changes in it at all and iths adds no
>> risk to the already approved changes
>> (http://svn.apache.org/viewvc?view=revision&revision=1079313).
>>
>> I believe the same change needs to be applied to the release branch
>> (or
>> else the changes that broke the built would need to be backed out).
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: QPID-3121: release branch broken on windows
Posted by Chuck Rolke <cr...@redhat.com>.
r1079313 is the correct patch to fix the 0.10 build issue which I just proved in a local build. I approve.
-Chuck
----- Original Message -----
> From: "Gordon Sim" <gs...@redhat.com>
> To: dev@qpid.apache.org
> Sent: Wednesday, March 9, 2011 10:55:53 AM
> Subject: QPID-3121: release branch broken on windows
> The changes committed to the release branch for QPID-3121 (Cluster
> management inconsistency when using persistent store) broke the
> windows
> build.
>
> I committed the trivial fix to the trunk for this already, which only
> affects linking and has no logic changes in it at all and iths adds no
> risk to the already approved changes
> (http://svn.apache.org/viewvc?view=revision&revision=1079313).
>
> I believe the same change needs to be applied to the release branch
> (or
> else the changes that broke the built would need to be backed out).
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org