You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/13 14:44:13 UTC
[GitHub] [maven-site] elharo opened a new pull request, #337: Clarify language around exclusions
elharo opened a new pull request, #337:
URL: https://github.com/apache/maven-site/pull/337
@michael-o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo merged pull request #337: Clarify language around exclusions
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #337:
URL: https://github.com/apache/maven-site/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] michael-o commented on a diff in pull request #337: Clarify language around exclusions
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #337:
URL: https://github.com/apache/maven-site/pull/337#discussion_r1097351617
##########
content/apt/pom.apt.vm:
##########
@@ -580,7 +583,7 @@ Display parameters as parsed by Maven (in canonical form and as a list of tokens
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-embedder</artifactId>
- <version>2.0</version>
+ <version>3.8.6</version>
Review Comment:
currentStableVersion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #337: Clarify language around exclusions
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #337:
URL: https://github.com/apache/maven-site/pull/337#discussion_r1097573679
##########
content/apt/pom.apt.vm:
##########
@@ -580,7 +583,7 @@ Display parameters as parsed by Maven (in canonical form and as a list of tokens
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-embedder</artifactId>
- <version>2.0</version>
+ <version>3.8.6</version>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #337: Clarify language around exclusions
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #337:
URL: https://github.com/apache/maven-site/pull/337#discussion_r1097312288
##########
content/apt/pom.apt.vm:
##########
@@ -567,10 +567,13 @@ Display parameters as parsed by Maven (in canonical form and as a list of tokens
*** {Exclusions}
- Exclusions tell Maven not to include the
- specified project that is a dependency of this dependency (in other words, its transitive
- dependency). For example, the <<<maven-embedder>>> requires <<<maven-core>>>, and we do not
- wish to use it or its dependencies, then we would add it as an <<<exclusion>>>.
+ It is sometimes useful to limit a dependency's transitive dependencies. A dependency may have incorrectly
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #337: Clarify language around exclusions
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #337:
URL: https://github.com/apache/maven-site/pull/337#discussion_r1097311266
##########
content/apt/pom.apt.vm:
##########
@@ -580,7 +583,7 @@ Display parameters as parsed by Maven (in canonical form and as a list of tokens
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-embedder</artifactId>
- <version>2.0</version>
+ <version>3.8.6</version>
Review Comment:
which property is that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] michael-o commented on a diff in pull request #337: Clarify language around exclusions
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #337:
URL: https://github.com/apache/maven-site/pull/337#discussion_r1020934571
##########
content/apt/pom.apt.vm:
##########
@@ -580,7 +583,7 @@ Display parameters as parsed by Maven (in canonical form and as a list of tokens
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-embedder</artifactId>
- <version>2.0</version>
+ <version>3.8.6</version>
Review Comment:
I think we even have a property for this in the POM.
##########
content/apt/pom.apt.vm:
##########
@@ -567,10 +567,13 @@ Display parameters as parsed by Maven (in canonical form and as a list of tokens
*** {Exclusions}
- Exclusions tell Maven not to include the
- specified project that is a dependency of this dependency (in other words, its transitive
- dependency). For example, the <<<maven-embedder>>> requires <<<maven-core>>>, and we do not
- wish to use it or its dependencies, then we would add it as an <<<exclusion>>>.
+ It is sometimes useful to limit a dependency's transitive dependencies. A dependency may have incorrectly
Review Comment:
double space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org