[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

[GitBox <gi...@apache.org>]

valepakh commented on code in PR #1479:
URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1069400175


##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/BaseMvStoragesTest.java:
##########
@@ -102,23 +104,20 @@ static void afterAll() {
         kBinaryConverter = null;
     }
 
-    protected static BinaryRow binaryKey(TestKey key) {
-        try {
-            return kvMarshaller.marshal(key);
-        } catch (MarshallerException e) {
-            throw new IgniteException(e);
-        }
+    protected static TableRow tableRow(TestKey key, TestValue value) {
+        return TableRowConverter.fromBinaryRow(binaryRow(key, value), kvBinaryConverter);

Review Comment:
   I would do it after the marshalers are converted to the TableRow interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org