[jira] [Comment Edited] (KAFKA-4738) Remove generic type of class ClientState

["Sharad (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856547#comment-15856547 ] 

Sharad edited comment on KAFKA-4738 at 2/7/17 6:58 PM:
-------------------------------------------------------

[~mjsax] TaskAssignor<C, T extends Comparable<T>> takes two generic arguments. Generic T is used for ClientState and TaskPair classes. Can the generic T for TaskAssignor be removed as well to TaskId?


was (Author: sharad.develop):
[~mjsax] TaskAssignor<C, T extends Comparable<T>> takes two generic arguments. Generic T is used for Client state and Task Pair. Can the generic T for TaskAssignor be removed as well to TaskId?

> Remove generic type of class ClientState
> ----------------------------------------
>
>                 Key: KAFKA-4738
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4738
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Sharad
>            Priority: Minor
>              Labels: beginner, newbie
>
> Currently, class {{org.apache.kafka.streams.processor.internals.assignment.ClientState<T>}} uses a generic type. However, within actual Streams code base the type will always be {{TaskId}} (from package {{org.apache.kafka.streams.processor}}).
> Thus, this ticket is about removing the generic type and replace it with {{TaskId}}, to simplify the code base.
> There are some tests, that use {{ClientState<Integer>}} (what allows for a slightly simplified test setup).  Those tests need to be updated to work properly using {{TaskId}} instead of {{Integer}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)