You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "AntiTopQuark (via GitHub)" <gi...@apache.org> on 2024/01/23 16:02:15 UTC
[PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
AntiTopQuark opened a new pull request, #2046:
URL: https://github.com/apache/kvrocks/pull/2046
https://github.com/apache/kvrocks/issues/2045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#discussion_r1464208605
##########
src/common/status.h:
##########
@@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {} // NOLINT
template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
This was caused by clang-format-16 behaving differently from clang-format-14, that said clang-format-16 will remove the space between the type and &&, but clang-format-14 won't do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "AntiTopQuark (via GitHub)" <gi...@apache.org>.
AntiTopQuark commented on PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#issuecomment-1906489927
> Seems lint failed, would you mind run `./x.py format` or using `clang-format` to format the edited file?
done, thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#discussion_r1463660253
##########
src/common/status.h:
##########
@@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {} // NOLINT
template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
cc @PragmaTwice 🤔 why would this file always get format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#discussion_r1464208605
##########
src/common/status.h:
##########
@@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {} // NOLINT
template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
This was caused by clang-format-16 behaves differently with clang-format-14, that said clang-format-16 will remove the space between the type and &&, but clang-format-14 won't do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#discussion_r1463660253
##########
src/common/status.h:
##########
@@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {} // NOLINT
template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
Would you mind revert this change?
Also cc @PragmaTwice 🤔 why would this file always get format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#issuecomment-1906437403
Seems lint failed, would you mind run `./x.py format` or using `clang-format` to format the edited file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(debug command): update err msg `int` -> `integer` [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#discussion_r1463660770
##########
src/common/status.h:
##########
@@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {} // NOLINT
template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
```suggestion
: BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org