You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by am...@apache.org on 2005/11/23 14:25:24 UTC

svn commit: r348435 - in /xerces/c/trunk/src/xercesc: dom/impl/DOMConfigurationImpl.cpp parsers/DOMLSParserImpl.cpp util/FileManagers/WindowsFileMgr.cpp

Author: amassari
Date: Wed Nov 23 05:25:14 2005
New Revision: 348435

URL: http://svn.apache.org/viewcvs?rev=348435&view=rev
Log:
Removed warnings

Modified:
    xerces/c/trunk/src/xercesc/dom/impl/DOMConfigurationImpl.cpp
    xerces/c/trunk/src/xercesc/parsers/DOMLSParserImpl.cpp
    xerces/c/trunk/src/xercesc/util/FileManagers/WindowsFileMgr.cpp

Modified: xerces/c/trunk/src/xercesc/dom/impl/DOMConfigurationImpl.cpp
URL: http://svn.apache.org/viewcvs/xerces/c/trunk/src/xercesc/dom/impl/DOMConfigurationImpl.cpp?rev=348435&r1=348434&r2=348435&view=diff
==============================================================================
--- xerces/c/trunk/src/xercesc/dom/impl/DOMConfigurationImpl.cpp (original)
+++ xerces/c/trunk/src/xercesc/dom/impl/DOMConfigurationImpl.cpp Wed Nov 23 05:25:14 2005
@@ -134,7 +134,7 @@
 // Query Methods
 // -----------------------------------------
 
-bool DOMConfigurationImpl::canSetParameter(const XMLCh* name, const void* value) const {
+bool DOMConfigurationImpl::canSetParameter(const XMLCh* name, const void* /*value*/) const {
 
     /**
      * canSetParameter(name, value) returns false in two conditions:

Modified: xerces/c/trunk/src/xercesc/parsers/DOMLSParserImpl.cpp
URL: http://svn.apache.org/viewcvs/xerces/c/trunk/src/xercesc/parsers/DOMLSParserImpl.cpp?rev=348435&r1=348434&r2=348435&view=diff
==============================================================================
--- xerces/c/trunk/src/xercesc/parsers/DOMLSParserImpl.cpp (original)
+++ xerces/c/trunk/src/xercesc/parsers/DOMLSParserImpl.cpp Wed Nov 23 05:25:14 2005
@@ -60,9 +60,9 @@
 {
 public:
     __AbortFilter() {}
-    virtual short acceptNode(DOMNode* node)      { return FILTER_INTERRUPT; }
-    virtual short startElement(DOMElement* node) { return FILTER_INTERRUPT; }
-    virtual unsigned long getWhatToShow() const  { return DOMNodeFilter::SHOW_ALL; }
+    virtual short acceptNode(DOMNode* /*node*/)      { return FILTER_INTERRUPT; }
+    virtual short startElement(DOMElement* /*node*/) { return FILTER_INTERRUPT; }
+    virtual unsigned long getWhatToShow() const      { return DOMNodeFilter::SHOW_ALL; }
 };
 
 static __AbortFilter g_AbortFilter;
@@ -602,7 +602,7 @@
         throw DOMException(DOMException::NOT_FOUND_ERR, 0, getMemoryManager());
 }
 
-bool DOMLSParserImpl::canSetParameter(const XMLCh* name, const void* value) const
+bool DOMLSParserImpl::canSetParameter(const XMLCh* name, const void* /*value*/) const
 {
     if (XMLString::compareIStringASCII(name, XMLUni::fgDOMResourceResolver) == 0 ||
         XMLString::compareIStringASCII(name, XMLUni::fgDOMErrorHandler) == 0 ||
@@ -617,7 +617,7 @@
     return false;
 }
 
-bool DOMLSParserImpl::canSetParameter(const XMLCh* name, bool value) const
+bool DOMLSParserImpl::canSetParameter(const XMLCh* name, bool /*value*/) const
 {
     if (XMLString::compareIStringASCII(name, XMLUni::fgDOMCharsetOverridesXMLEncoding) == 0 ||
         XMLString::compareIStringASCII(name, XMLUni::fgDOMDisallowDoctype) == 0 ||

Modified: xerces/c/trunk/src/xercesc/util/FileManagers/WindowsFileMgr.cpp
URL: http://svn.apache.org/viewcvs/xerces/c/trunk/src/xercesc/util/FileManagers/WindowsFileMgr.cpp?rev=348435&r1=348434&r2=348435&view=diff
==============================================================================
--- xerces/c/trunk/src/xercesc/util/FileManagers/WindowsFileMgr.cpp (original)
+++ xerces/c/trunk/src/xercesc/util/FileManagers/WindowsFileMgr.cpp Wed Nov 23 05:25:14 2005
@@ -178,7 +178,7 @@
 
 
 FileHandle
-WindowsFileMgr::open(const char* path, bool toWrite, MemoryManager* const manager)
+WindowsFileMgr::open(const char* path, bool toWrite, MemoryManager* const /*manager*/)
 {
     FileHandle retVal = ::CreateFileA
     (
@@ -312,19 +312,14 @@
 
     const XMLByte* tmpFlush = buffer;
 
-    while (true)
+    while (byteCount > 0)
     {
-        unsigned long  bytesWritten = 0;
+        unsigned long bytesWritten = 0;
         if (!::WriteFile(f, tmpFlush, byteCount, &bytesWritten, 0))
             ThrowXMLwithMemMgr(XMLPlatformUtilsException, XMLExcepts::File_CouldNotWriteToFile, manager);
 
-        if (bytesWritten < byteCount) //incomplete write
-        {
-            tmpFlush+=bytesWritten;
-            byteCount-=bytesWritten;
-        }
-        else
-            return;
+        tmpFlush+=bytesWritten;
+        byteCount-=bytesWritten;
     }
 }
 
@@ -406,7 +401,7 @@
 
 
 bool
-WindowsFileMgr::isRelative(const XMLCh* const toCheck, MemoryManager* const manager)
+WindowsFileMgr::isRelative(const XMLCh* const toCheck, MemoryManager* const /*manager*/)
 {
     // Check for pathological case of empty path
     if (!toCheck || !toCheck[0])



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org