You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2002/07/25 02:29:18 UTC
svnadmin lsrevs grows without bounds
On my repository using revision 2685, running svnadmin lsrevs uses
all the available memory on my system (256 Mbytes) before I have
to kill it.
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnadmin lsrevs grows without bounds
Posted by Blair Zajac <bl...@orcaware.com>.
Blair Zajac wrote:
>
> cmpilato@collab.net wrote:
> >
> > Blair Zajac <bl...@orcaware.com> writes:
> >
> > > cmpilato@collab.net wrote:
> > > >
> > > > Blair Zajac <bl...@orcaware.com> writes:
> > > >
> > > > > On my repository using revision 2685, running svnadmin lsrevs uses
> > > > > all the available memory on my system (256 Mbytes) before I have
> > > > > to kill it.
> > > >
> > > > Don't do that!
> > > >
> > > > Seriously, try this patch to svnadmin/main.c -- does it affect anything?
> > >
> > > No, it didn't help. I got through ~120 revisions and it was using 250
> > > Mbytes of memory again.
> >
> > I think I've found the problem. Will commit up soon.
OK. That did the trick. It slowly grew from ~2 to a maximum of 3.2
Mbytes now over 144 revisions.
Thanks,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnadmin lsrevs grows without bounds
Posted by Blair Zajac <bl...@orcaware.com>.
cmpilato@collab.net wrote:
>
> Blair Zajac <bl...@orcaware.com> writes:
>
> > cmpilato@collab.net wrote:
> > >
> > > Blair Zajac <bl...@orcaware.com> writes:
> > >
> > > > On my repository using revision 2685, running svnadmin lsrevs uses
> > > > all the available memory on my system (256 Mbytes) before I have
> > > > to kill it.
> > >
> > > Don't do that!
> > >
> > > Seriously, try this patch to svnadmin/main.c -- does it affect anything?
> >
> > No, it didn't help. I got through ~120 revisions and it was using 250
> > Mbytes of memory again.
>
> I think I've found the problem. Will commit up soon.
Thanks. I'll try this later tonight or tomorrow.
There's a compiler warning now:
subversion/svnadmin/main.c: In function `main':
subversion/svnadmin/main.c:381: warning: `this_pool' might be used uninitialized
in this function
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnadmin lsrevs grows without bounds
Posted by cm...@collab.net.
Blair Zajac <bl...@orcaware.com> writes:
> cmpilato@collab.net wrote:
> >
> > Blair Zajac <bl...@orcaware.com> writes:
> >
> > > On my repository using revision 2685, running svnadmin lsrevs uses
> > > all the available memory on my system (256 Mbytes) before I have
> > > to kill it.
> >
> > Don't do that!
> >
> > Seriously, try this patch to svnadmin/main.c -- does it affect anything?
>
> No, it didn't help. I got through ~120 revisions and it was using 250
> Mbytes of memory again.
I think I've found the problem. Will commit up soon.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnadmin lsrevs grows without bounds
Posted by Blair Zajac <bl...@orcaware.com>.
cmpilato@collab.net wrote:
>
> Blair Zajac <bl...@orcaware.com> writes:
>
> > On my repository using revision 2685, running svnadmin lsrevs uses
> > all the available memory on my system (256 Mbytes) before I have
> > to kill it.
>
> Don't do that!
>
> Seriously, try this patch to svnadmin/main.c -- does it affect anything?
No, it didn't help. I got through ~120 revisions and it was using 250
Mbytes of memory again.
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnadmin lsrevs grows without bounds
Posted by cm...@collab.net.
Blair Zajac <bl...@orcaware.com> writes:
> On my repository using revision 2685, running svnadmin lsrevs uses
> all the available memory on my system (256 Mbytes) before I have
> to kill it.
Don't do that!
Seriously, try this patch to svnadmin/main.c -- does it affect anything?
Index: ./main.c
===================================================================
--- ./main.c
+++ ./main.c Wed Jul 24 21:37:47 2002
@@ -461,6 +461,7 @@
case svnadmin_cmd_lsrevs:
{
+ apr_pool_t *this_pool = svn_pool_create (pool);
svn_revnum_t
lower = SVN_INVALID_REVNUM,
upper = SVN_INVALID_REVNUM,
@@ -493,7 +494,6 @@
svn_string_t *datestamp;
svn_string_t *author;
svn_string_t *log;
- apr_pool_t *this_pool = svn_pool_create (pool);
const svn_fs_id_t *root_id;
svn_string_t *id_str;
const char *datestamp_native, *author_native, *log_native;
@@ -526,14 +526,15 @@
printf ("Log (%" APR_SIZE_T_FMT " bytes):\n%s\n",
log->len, log_native);
printf ("==========================================\n");
- INT_ERR (svn_fs_node_id (&root_id, this_root, "", pool));
- id_str = svn_fs_unparse_id (root_id, pool);
+ INT_ERR (svn_fs_node_id (&root_id, this_root, "", this_pool));
+ id_str = svn_fs_unparse_id (root_id, this_pool);
printf ("/ <%s>\n", id_str->data);
print_tree (this_root, "", 1, this_pool);
printf ("\n");
- svn_pool_destroy (this_pool);
+ svn_pool_clear (this_pool);
}
+ svn_pool_destroy (this_pool);
}
break;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org