You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/11 04:49:45 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #885: rename
customized state aggregation config to customized state config
zhangmeng916 opened a new pull request #885: rename customized state aggregation config to customized state config
URL: https://github.com/apache/helix/pull/885
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
(#850 )
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Rename the customized state aggregation config to customize state config throughout the code base. The main reason for this change is that we may use the config to represent other feature for customized state in addition to aggregation feature.
### Tests
- [X] The following is the result of the "mvn test" command on the appropriate module:
[INFO] Tests run: 909, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,438.097 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 909, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
### Commits
- [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [X] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on issue #885: rename customized
state aggregation config to customized state config
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on issue #885: rename customized state aggregation config to customized state config
URL: https://github.com/apache/helix/pull/885#issuecomment-597454214
This PR is ready to merge, approved by @jiajunwang
Final commit message:
Rename customized state aggregation config to customized state config for future extendibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on issue #885: rename customized
state aggregation config to customized state config
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on issue #885: rename customized state aggregation config to customized state config
URL: https://github.com/apache/helix/pull/885#issuecomment-597454071
> LGTM. Thanks for refactoring.
> Just to confirm, there seems to be no logic change, right?
No logic change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #885: rename customized
state aggregation config to customized state config
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #885: rename customized state aggregation config to customized state config
URL: https://github.com/apache/helix/pull/885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org