You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/25 11:59:15 UTC
[GitHub] [skywalking] wyt opened a new pull request, #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
wyt opened a new pull request, #8945:
URL: https://github.com/apache/skywalking/pull/8945
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/changelog/docs/en/changes/changes.md).
When the oap cluster uses nacos, if `internalComHost` and `internalComPort` are not set, an instance with an IP of 0.0.0.0 is always registered in nacos. Can it be obtained automatically in the program to reduce the difficulty of use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #8945:
URL: https://github.com/apache/skywalking/pull/8945#issuecomment-1108660427
You should read this
https://github.com/apache/skywalking/blob/5c247b8d7fa5fa7279f95a5f96d028c0fe0fa3c1/oap-server/server-cluster-plugin/cluster-nacos-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/nacos/NacosCoordinator.java#L71
Actually, SkyWalking is already responding **unhealthy** status.
Check the official doc, https://skywalking.apache.org/docs/main/v9.0.0/en/setup/backend/backend-health-check/#health-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wyt commented on pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
Posted by GitBox <gi...@apache.org>.
wyt commented on PR #8945:
URL: https://github.com/apache/skywalking/pull/8945#issuecomment-1108648966
> Ww discussed about this before, 2 things
>
> 1. Use this setup means you have known what to do, and what does this setup mean
> 2. Use the first IP address doesn't change the fact it still could be wrong. A little approvement, but not much
>
> And from the code perspective, if this is going to be accepted, we have to change all cluster manager implementations, besides k8s as it is automatically working.
The automatic setting solves the problem in most cases, in a few cases it can be set manually, you are correct, need to change all cluster manager implementations, I didn't realize this at first. It is recommended that the official make a unified improvement on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #8945:
URL: https://github.com/apache/skywalking/pull/8945#issuecomment-1108691061
That is what we design from official perspective. Automatically address picking up in here, if user uses 127.0.0.1 as listening port, it still causes the similar issue.
If you want to avoid this, I think the current logic is not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wyt closed pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
Posted by GitBox <gi...@apache.org>.
wyt closed pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
URL: https://github.com/apache/skywalking/pull/8945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #8945:
URL: https://github.com/apache/skywalking/pull/8945#issuecomment-1108488452
Ww discussed about this before, 2 things
1. Use this setup means you have known what to do, and what does this setup mean
2. Use the first IP address doesn't change the fact it still could be wrong. A little approvement, but not much
And from the code perspective, if this is going to be accepted, we have to change all cluster manager implementations, besides k8s as it is automatically working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wyt commented on pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.
Posted by GitBox <gi...@apache.org>.
wyt commented on PR #8945:
URL: https://github.com/apache/skywalking/pull/8945#issuecomment-1108668898
> You should read this
>
> https://github.com/apache/skywalking/blob/5c247b8d7fa5fa7279f95a5f96d028c0fe0fa3c1/oap-server/server-cluster-plugin/cluster-nacos-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/nacos/NacosCoordinator.java#L71
>
> Actually, SkyWalking is already responding **unhealthy** status.
>
> Check the official doc, https://skywalking.apache.org/docs/main/v9.0.0/en/setup/backend/backend-health-check/#health-check
Thanks for letting me know about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org