You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Ting Yao,Huang (Jira)" <ji...@apache.org> on 2021/02/17 06:25:00 UTC

[jira] [Resolved] (YUNIKORN-509) Simplify the gangDeploy.sh

     [ https://issues.apache.org/jira/browse/YUNIKORN-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ting Yao,Huang resolved YUNIKORN-509.
-------------------------------------
    Resolution: Fixed

> Simplify the gangDeploy.sh
> --------------------------
>
>                 Key: YUNIKORN-509
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-509
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: shim - kubernetes
>            Reporter: Weiwei Yang
>            Assignee: Ting Yao,Huang
>            Priority: Minor
>              Labels: pull-request-available
>
> This is a follow up to the review comment: https://github.com/apache/incubator-yunikorn-k8shim/pull/219#discussion_r557336617. We can simplify the script by splitting a yaml file for the content encoded in the script itself. See more in the review comment from [~kmarton].
> Also Kinga mentioned we need to add a timeout for:
> {code}
> until grep 'Running' <(kubectl get pod gangweb -o=jsonpath='{.status.phase}'); do
>   sleep 1
> done
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org