You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shiro.apache.org by "Jochen Kemnade (JIRA)" <ji...@apache.org> on 2015/04/09 17:11:13 UTC

[jira] [Commented] (SHIRO-498) ThreadLocal should not be created when not necessary

    [ https://issues.apache.org/jira/browse/SHIRO-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487488#comment-14487488 ] 

Jochen Kemnade commented on SHIRO-498:
--------------------------------------

Any news on this? Is there anything I can do here? The leaking ThreadLocals keep on causing issues during CI/automatic releployment for us.

> ThreadLocal should not be created when not necessary
> ----------------------------------------------------
>
>                 Key: SHIRO-498
>                 URL: https://issues.apache.org/jira/browse/SHIRO-498
>             Project: Shiro
>          Issue Type: Improvement
>    Affects Versions: 1.2.2
>            Reporter: Jochen Kemnade
>            Assignee: Kalle Korhonen
>              Labels: patch
>         Attachments: 0001-don-t-create-ThreadLocals-when-not-needed.patch
>
>
> org.apache.shiro.util.ThreadContext.getValue(Object) and org.apache.shiro.util.ThreadContext.remove(Object) initialze the TheadLocal unnecessarily via initialValue(). Both methods should return without creating the ThreadLocal to avoid potential memory leaks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)