You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shivusondur <gi...@git.apache.org> on 2018/10/08 04:38:57 UTC
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
GitHub user shivusondur opened a pull request:
https://github.com/apache/spark/pull/22668
[SPARK-25675] [Spark Job History] Job UI page does not show pagination with one page
## What changes were proposed in this pull request?
Currently in PagedTable.scala pageNavigation() method, if it is having only one page, they were not using the pagination.
Now it made to use the pagination, even if it is having one page.
## How was this patch tested?
This tested with Spark webUI and History page in spark local setup.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shivusondur/spark pagination
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22668.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22668
----
commit 08328c9fd41787b0bd6c81d077f6d917d57690a2
Author: shivusondur <sh...@...>
Date: 2018-10-08T04:32:28Z
[SPARK-25675] [Spark Job History] Job UI page does not show pagination with one page
Removed the check for single page and made to show pagination for even single page
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22668
@srowen I think it is easy fix, let me fix it now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22668
(I did the same thing 2 weeks ago)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224316034
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -123,10 +123,9 @@ private[ui] trait PagedTable[T] {
/**
* Return a page navigation.
* <ul>
- * <li>If the totalPages is 1, the page navigation will be empty</li>
* <li>
- * If the totalPages is more than 1, it will create a page navigation including a group of
- * page numbers and a form to submit the page number.
+ * It will create a page navigation including a group of page numbers and a form
--- End diff --
true.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22668
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22668
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22668
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by shivusondur <gi...@git.apache.org>.
Github user shivusondur commented on the issue:
https://github.com/apache/spark/pull/22668
@felixcheung
OK. Thank you.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22668
merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Posted by shivusondur <gi...@git.apache.org>.
Github user shivusondur commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224318421
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -123,10 +123,9 @@ private[ui] trait PagedTable[T] {
/**
* Return a page navigation.
* <ul>
- * <li>If the totalPages is 1, the page navigation will be empty</li>
* <li>
- * If the totalPages is more than 1, it will create a page navigation including a group of
- * page numbers and a form to submit the page number.
+ * It will create a page navigation including a group of page numbers and a form
--- End diff --
@gengliangwang @felixcheung
i have updated according to your suggestion. please check.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22668
@shivusondur @felixcheung looks like this test fails: https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-2.7/5070/testReport/org.apache.spark.ui/PagedTableSuite/pageNavigation/
Looks like we didn't get a PR builder test on this one. Easy to fix or should we revert temporarily?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by shivusondur <gi...@git.apache.org>.
Github user shivusondur commented on the issue:
https://github.com/apache/spark/pull/22668
@gengliangwang @felixcheung If everything okay, can you please merge the PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224323509
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -154,9 +150,6 @@ private[ui] trait PagedTable[T] {
* }}}
*/
private[ui] def pageNavigation(page: Int, pageSize: Int, totalPages: Int): Seq[Node] = {
- if (totalPages == 1) {
- Nil
- } else {
--- End diff --
One more comment: need to adjust the indent of the following code block.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Posted by shivusondur <gi...@git.apache.org>.
Github user shivusondur commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224337547
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -154,9 +150,6 @@ private[ui] trait PagedTable[T] {
* }}}
*/
private[ui] def pageNavigation(page: Int, pageSize: Int, totalPages: Int): Seq[Node] = {
- if (totalPages == 1) {
- Nil
- } else {
--- End diff --
Thanks for reviewing,
handled your comment, showing more difference because of white-space.
please check
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by shivusondur <gi...@git.apache.org>.
Github user shivusondur commented on the issue:
https://github.com/apache/spark/pull/22668
@felixcheung If the user inputs **rowcount** in **Show** tab such that all the rows comes in one page,
From here on user can't see the pagination and he will not able to inputs **rowcount** again to see pagination.
To see pagination, he has to refresh the entire page again.
In the Executors page even in one page it is showing the pagination
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22668
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224101829
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -123,10 +123,9 @@ private[ui] trait PagedTable[T] {
/**
* Return a page navigation.
* <ul>
- * <li>If the totalPages is 1, the page navigation will be empty</li>
* <li>
- * If the totalPages is more than 1, it will create a page navigation including a group of
- * page numbers and a form to submit the page number.
+ * It will create a page navigation including a group of page numbers and a form
--- End diff --
I don't think we need to put this comment inside `<ul><li>..</li></ul>`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by shivusondur <gi...@git.apache.org>.
Github user shivusondur commented on the issue:
https://github.com/apache/spark/pull/22668
@felixcheung
Thanks for merging.
My account name in jira is : shivusondur@gmail.com
This issue is assigned to me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22668
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22668
ouch sorry
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22668
@shivusondur
what's your account name on https://issues.apache.org?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org