You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2015/11/30 10:14:46 UTC

Review Request 40790: Invalid session handle error in hive view when hive server is restarted in http mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40790/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-14109
    https://issues.apache.org/jira/browse/AMBARI-14109


Repository: ambari


Description
-------

Removing session when we get Invalid session in query response.


Diffs
-----

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 451f2aa 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Cursor.java 16fdf36 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/DDLDelegator.java eda12ed 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java 1b565eb 

Diff: https://reviews.apache.org/r/40790/diff/


Testing
-------

Manual testing.


Thanks,

Gaurav Nagar


Re: Review Request 40790: Invalid session handle error in hive view when hive server is restarted in http mode

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40790/#review108461
-----------------------------------------------------------



contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java (line 39)
<https://reviews.apache.org/r/40790/#comment167916>

    Leave this constructor as is, add the new constructor and from the old constructor call this(connection, null) rather than changing the code in Connection.java and multiple other place.


- DIPAYAN BHOWMICK


On Nov. 30, 2015, 9:14 a.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40790/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 9:14 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14109
>     https://issues.apache.org/jira/browse/AMBARI-14109
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removing session when we get Invalid session in query response.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 451f2aa 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Cursor.java 16fdf36 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/DDLDelegator.java eda12ed 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java 1b565eb 
> 
> Diff: https://reviews.apache.org/r/40790/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>


Re: Review Request 40790: Invalid session handle error in hive view when hive server is restarted in http mode

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40790/#review108711
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Dec. 1, 2015, 9:22 a.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40790/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 9:22 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14109
>     https://issues.apache.org/jira/browse/AMBARI-14109
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removing session when we get Invalid session in query response.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 451f2aa 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/DDLDelegator.java eda12ed 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java 1b565eb 
> 
> Diff: https://reviews.apache.org/r/40790/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>


Re: Review Request 40790: Invalid session handle error in hive view when hive server is restarted in http mode

Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40790/#review108511
-----------------------------------------------------------

Ship it!


Ship It!

- Rohit Choudhary


On Dec. 1, 2015, 9:22 a.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40790/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 9:22 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14109
>     https://issues.apache.org/jira/browse/AMBARI-14109
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removing session when we get Invalid session in query response.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 451f2aa 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/DDLDelegator.java eda12ed 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java 1b565eb 
> 
> Diff: https://reviews.apache.org/r/40790/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>


Re: Review Request 40790: Invalid session handle error in hive view when hive server is restarted in http mode

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40790/#review108498
-----------------------------------------------------------

Ship it!


Ship It!

- DIPAYAN BHOWMICK


On Dec. 1, 2015, 9:22 a.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40790/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 9:22 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14109
>     https://issues.apache.org/jira/browse/AMBARI-14109
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removing session when we get Invalid session in query response.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 451f2aa 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/DDLDelegator.java eda12ed 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java 1b565eb 
> 
> Diff: https://reviews.apache.org/r/40790/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>


Re: Review Request 40790: Invalid session handle error in hive view when hive server is restarted in http mode

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40790/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 9:22 a.m.)


Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Changes
-------

Changes as suggested in comments


Bugs: AMBARI-14109
    https://issues.apache.org/jira/browse/AMBARI-14109


Repository: ambari


Description
-------

Removing session when we get Invalid session in query response.


Diffs (updated)
-----

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 451f2aa 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/DDLDelegator.java eda12ed 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java 1b565eb 

Diff: https://reviews.apache.org/r/40790/diff/


Testing
-------

Manual testing.


Thanks,

Gaurav Nagar