You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/11/23 07:53:07 UTC
[PR] [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test [spark]
zhengruifeng opened a new pull request, #43975:
URL: https://github.com/apache/spark/pull/43975
### What changes were proposed in this pull request?
Upgrade to Python 3.9 in daily maven test
### Why are the changes needed?
to be consistent with https://github.com/apache/spark/pull/43902
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43975:
URL: https://github.com/apache/spark/pull/43975#issuecomment-1823937019
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43975:
URL: https://github.com/apache/spark/pull/43975#discussion_r1403025877
##########
.github/workflows/maven_test.yml:
##########
@@ -152,20 +152,20 @@ jobs:
with:
distribution: temurin
java-version: ${{ matrix.java }}
- - name: Install Python 3.8
+ - name: Install Python 3.9
uses: actions/setup-python@v4
# We should install one Python that is higher than 3+ for SQL and Yarn because:
# - SQL component also has Python related tests, for example, IntegratedUDFTestUtils.
# - Yarn has a Python specific test too, for example, YarnClusterSuite.
if: contains(matrix.modules, 'resource-managers#yarn') || (contains(matrix.modules, 'sql#core'))
with:
- python-version: 3.8
+ python-version: '3.9'
architecture: x64
- - name: Install Python packages (Python 3.8)
+ - name: Install Python packages (Python 3.9)
if: (contains(matrix.modules, 'sql#core'))
run: |
- python3.8 -m pip install 'numpy>=1.20.0' pyarrow pandas scipy unittest-xml-reporting 'grpcio==1.56.0' 'protobuf==3.20.3'
- python3.8 -m pip list
+ python3.9 -m pip install 'numpy>=1.20.0' pyarrow pandas scipy unittest-xml-reporting 'grpcio==1.56.0' 'protobuf==3.20.3'
Review Comment:
Do the versions of the modules need to be upgraded simultaneously? like `grpcio`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43975:
URL: https://github.com/apache/spark/pull/43975#issuecomment-1823962199
merged to master, thanks @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #43975: [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test
URL: https://github.com/apache/spark/pull/43975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43975:
URL: https://github.com/apache/spark/pull/43975#discussion_r1403025877
##########
.github/workflows/maven_test.yml:
##########
@@ -152,20 +152,20 @@ jobs:
with:
distribution: temurin
java-version: ${{ matrix.java }}
- - name: Install Python 3.8
+ - name: Install Python 3.9
uses: actions/setup-python@v4
# We should install one Python that is higher than 3+ for SQL and Yarn because:
# - SQL component also has Python related tests, for example, IntegratedUDFTestUtils.
# - Yarn has a Python specific test too, for example, YarnClusterSuite.
if: contains(matrix.modules, 'resource-managers#yarn') || (contains(matrix.modules, 'sql#core'))
with:
- python-version: 3.8
+ python-version: '3.9'
architecture: x64
- - name: Install Python packages (Python 3.8)
+ - name: Install Python packages (Python 3.9)
if: (contains(matrix.modules, 'sql#core'))
run: |
- python3.8 -m pip install 'numpy>=1.20.0' pyarrow pandas scipy unittest-xml-reporting 'grpcio==1.56.0' 'protobuf==3.20.3'
- python3.8 -m pip list
+ python3.9 -m pip install 'numpy>=1.20.0' pyarrow pandas scipy unittest-xml-reporting 'grpcio==1.56.0' 'protobuf==3.20.3'
Review Comment:
I think the versions of the modules need to be upgraded simultaneously, like `grpcio` and `protobuf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46002][INFRA][FOLLOWUP] Upgrade to Python 3.9 in daily maven test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #43975:
URL: https://github.com/apache/spark/pull/43975#discussion_r1403026626
##########
.github/workflows/maven_test.yml:
##########
@@ -152,20 +152,20 @@ jobs:
with:
distribution: temurin
java-version: ${{ matrix.java }}
- - name: Install Python 3.8
+ - name: Install Python 3.9
uses: actions/setup-python@v4
# We should install one Python that is higher than 3+ for SQL and Yarn because:
# - SQL component also has Python related tests, for example, IntegratedUDFTestUtils.
# - Yarn has a Python specific test too, for example, YarnClusterSuite.
if: contains(matrix.modules, 'resource-managers#yarn') || (contains(matrix.modules, 'sql#core'))
with:
- python-version: 3.8
+ python-version: '3.9'
architecture: x64
- - name: Install Python packages (Python 3.8)
+ - name: Install Python packages (Python 3.9)
if: (contains(matrix.modules, 'sql#core'))
run: |
- python3.8 -m pip install 'numpy>=1.20.0' pyarrow pandas scipy unittest-xml-reporting 'grpcio==1.56.0' 'protobuf==3.20.3'
- python3.8 -m pip list
+ python3.9 -m pip install 'numpy>=1.20.0' pyarrow pandas scipy unittest-xml-reporting 'grpcio==1.56.0' 'protobuf==3.20.3'
Review Comment:
good point, I think is should be the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org