You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by willholley <gi...@git.apache.org> on 2016/05/16 11:26:01 UTC

[GitHub] couchdb-chttpd pull request: use shard suffix when generating _cha...

Github user willholley commented on the pull request:

    https://github.com/apache/couchdb-chttpd/pull/120#issuecomment-219404101
  
    I'd like to add tests for this but not quite sure where the appropriate place is. 
    
    Also, this pattern is repeated  at https://github.com/apache/couchdb-global-changes/blob/203fb088ed81149108e64d18ffd9c3f5df154f97/src/global_changes_httpd.erl#L55 and https://github.com/apache/couchdb-couch/blob/b4295bfe58680c6a3d332a73ac6b061bd78b4db3/src/couch_httpd_db.erl#L123.
    
    This makes me wonder whether changing the database info object to include the unique shard prefix would be a better solution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---