You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2010/05/25 12:18:23 UTC
[jira] Created: (JCR-2638) Litmus locks test failures
Litmus locks test failures
--------------------------
Key: JCR-2638
URL: https://issues.apache.org/jira/browse/JCR-2638
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-jcr-server, jackrabbit-webdav
Affects Versions: 2.1.0
Reporter: Jukka Zitting
Priority: Minor
The locks part of the Litmus test suite contains a few warnings and failures when run against Jackrabbit:
-> running `locks':
0. init.................. pass
1. begin................. pass
2. options............... pass
3. precond............... pass
4. init_locks............ pass
5. put................... pass
6. lock_excl............. pass
7. discover.............. pass
8. refresh............... pass
9. notowner_modify....... pass
10. notowner_lock......... [Fatal Error] :1:1: Content is not allowed in prolog.
pass
11. owner_modify.......... pass
12. notowner_modify....... pass
13. notowner_lock......... [Fatal Error] :1:1: Content is not allowed in prolog.
pass
14. copy.................. pass
15. cond_put.............. pass
16. fail_cond_put......... pass
17. cond_put_with_not..... pass
18. cond_put_corrupt_token WARNING: PUT failed with 412 not 423
...................... pass (with 1 warning)
19. complex_cond_put...... pass
20. fail_complex_cond_put. pass
21. unlock................ [Fatal Error] :1:1: Content is not allowed in prolog.
FAIL (UNLOCK on `/default/litmus/lockme': 400 Bad Request)
22. fail_cond_put_unlocked pass
23. lock_shared........... FAIL (LOCK on `/default/litmus/lockme': 412 Precondition Failed)
24. notowner_modify....... SKIPPED
25. notowner_lock......... SKIPPED
26. owner_modify.......... SKIPPED
27. double_sharedlock..... SKIPPED
28. notowner_modify....... SKIPPED
29. notowner_lock......... SKIPPED
30. unlock................ SKIPPED
31. prep_collection....... pass
32. lock_collection....... pass
33. owner_modify.......... pass
34. notowner_modify....... pass
35. refresh............... pass
36. indirect_refresh...... pass
37. unlock................ pass
38. unmapped_lock......... WARNING: LOCK on unmapped url returned 200 not 201 (RFC4918:S7.3)
...................... pass (with 1 warning)
39. unlock................ FAIL (UNLOCK on `/default/litmus/unmapped_url': 412 Precondition Failed)
40. finish................ pass
-> 7 tests were skipped.
<- summary for `locks': of 34 tests run: 31 passed, 3 failed. 91.2%
-> 2 warnings were issued.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2638) Litmus locks test failures
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910385#action_12910385 ]
Jukka Zitting commented on JCR-2638:
------------------------------------
Good stuff, thanks! I committed a slightly modified version of the fix in revision 997947.
> Litmus locks test failures
> --------------------------
>
> Key: JCR-2638
> URL: https://issues.apache.org/jira/browse/JCR-2638
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr-server, jackrabbit-webdav
> Affects Versions: 2.1.0
> Reporter: Jukka Zitting
> Priority: Minor
>
> The locks part of the Litmus test suite contains a few warnings and failures when run against Jackrabbit:
> -> running `locks':
> 0. init.................. pass
> 1. begin................. pass
> 2. options............... pass
> 3. precond............... pass
> 4. init_locks............ pass
> 5. put................... pass
> 6. lock_excl............. pass
> 7. discover.............. pass
> 8. refresh............... pass
> 9. notowner_modify....... pass
> 10. notowner_lock......... [Fatal Error] :1:1: Content is not allowed in prolog.
> pass
> 11. owner_modify.......... pass
> 12. notowner_modify....... pass
> 13. notowner_lock......... [Fatal Error] :1:1: Content is not allowed in prolog.
> pass
> 14. copy.................. pass
> 15. cond_put.............. pass
> 16. fail_cond_put......... pass
> 17. cond_put_with_not..... pass
> 18. cond_put_corrupt_token WARNING: PUT failed with 412 not 423
> ...................... pass (with 1 warning)
> 19. complex_cond_put...... pass
> 20. fail_complex_cond_put. pass
> 21. unlock................ [Fatal Error] :1:1: Content is not allowed in prolog.
> FAIL (UNLOCK on `/default/litmus/lockme': 400 Bad Request)
> 22. fail_cond_put_unlocked pass
> 23. lock_shared........... FAIL (LOCK on `/default/litmus/lockme': 412 Precondition Failed)
> 24. notowner_modify....... SKIPPED
> 25. notowner_lock......... SKIPPED
> 26. owner_modify.......... SKIPPED
> 27. double_sharedlock..... SKIPPED
> 28. notowner_modify....... SKIPPED
> 29. notowner_lock......... SKIPPED
> 30. unlock................ SKIPPED
> 31. prep_collection....... pass
> 32. lock_collection....... pass
> 33. owner_modify.......... pass
> 34. notowner_modify....... pass
> 35. refresh............... pass
> 36. indirect_refresh...... pass
> 37. unlock................ pass
> 38. unmapped_lock......... WARNING: LOCK on unmapped url returned 200 not 201 (RFC4918:S7.3)
> ...................... pass (with 1 warning)
> 39. unlock................ FAIL (UNLOCK on `/default/litmus/unmapped_url': 412 Precondition Failed)
> 40. finish................ pass
> -> 7 tests were skipped.
> <- summary for `locks': of 34 tests run: 31 passed, 3 failed. 91.2%
> -> 2 warnings were issued.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2638) Litmus locks test failures
Posted by "Javier Godoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906358#action_12906358 ]
Javier Godoy commented on JCR-2638:
-----------------------------------
38. unmapped_lock......... WARNING: LOCK on unmapped url returned 200 not 201 (RFC4918:S7.3).
In AbstractWebDavServlet:785 (doLock) replace the else block by:
else {
// create a new lock
int status = resource.exists()?SC_OK:SC_CREATED;
ActiveLock lock = resource.lock(lockInfo);
//we cannot use response.sendLockResponse(lock);
//because lock-empty requires status code 201 (Created)
CodedUrlHeader ltHeader = new CodedUrlHeader(DavConstants.HEADER_LOCK_TOKEN, lock.getToken());
response.setHeader(ltHeader.getHeaderName(), ltHeader.getHeaderValue());
DavPropertySet propSet = new DavPropertySet();
propSet.add(new LockDiscovery(lock));
response.sendXmlResponse(propSet, status);
}
> Litmus locks test failures
> --------------------------
>
> Key: JCR-2638
> URL: https://issues.apache.org/jira/browse/JCR-2638
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr-server, jackrabbit-webdav
> Affects Versions: 2.1.0
> Reporter: Jukka Zitting
> Priority: Minor
>
> The locks part of the Litmus test suite contains a few warnings and failures when run against Jackrabbit:
> -> running `locks':
> 0. init.................. pass
> 1. begin................. pass
> 2. options............... pass
> 3. precond............... pass
> 4. init_locks............ pass
> 5. put................... pass
> 6. lock_excl............. pass
> 7. discover.............. pass
> 8. refresh............... pass
> 9. notowner_modify....... pass
> 10. notowner_lock......... [Fatal Error] :1:1: Content is not allowed in prolog.
> pass
> 11. owner_modify.......... pass
> 12. notowner_modify....... pass
> 13. notowner_lock......... [Fatal Error] :1:1: Content is not allowed in prolog.
> pass
> 14. copy.................. pass
> 15. cond_put.............. pass
> 16. fail_cond_put......... pass
> 17. cond_put_with_not..... pass
> 18. cond_put_corrupt_token WARNING: PUT failed with 412 not 423
> ...................... pass (with 1 warning)
> 19. complex_cond_put...... pass
> 20. fail_complex_cond_put. pass
> 21. unlock................ [Fatal Error] :1:1: Content is not allowed in prolog.
> FAIL (UNLOCK on `/default/litmus/lockme': 400 Bad Request)
> 22. fail_cond_put_unlocked pass
> 23. lock_shared........... FAIL (LOCK on `/default/litmus/lockme': 412 Precondition Failed)
> 24. notowner_modify....... SKIPPED
> 25. notowner_lock......... SKIPPED
> 26. owner_modify.......... SKIPPED
> 27. double_sharedlock..... SKIPPED
> 28. notowner_modify....... SKIPPED
> 29. notowner_lock......... SKIPPED
> 30. unlock................ SKIPPED
> 31. prep_collection....... pass
> 32. lock_collection....... pass
> 33. owner_modify.......... pass
> 34. notowner_modify....... pass
> 35. refresh............... pass
> 36. indirect_refresh...... pass
> 37. unlock................ pass
> 38. unmapped_lock......... WARNING: LOCK on unmapped url returned 200 not 201 (RFC4918:S7.3)
> ...................... pass (with 1 warning)
> 39. unlock................ FAIL (UNLOCK on `/default/litmus/unmapped_url': 412 Precondition Failed)
> 40. finish................ pass
> -> 7 tests were skipped.
> <- summary for `locks': of 34 tests run: 31 passed, 3 failed. 91.2%
> -> 2 warnings were issued.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.