You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/25 04:14:36 UTC
[GitHub] [spark] dchvn opened a new pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
dchvn opened a new pull request #34375:
URL: https://github.com/apache/spark/pull/34375
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->Inline type hints for python/pyspark/status.py
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->We can take advantage of static type checking within the functions by inlining the type hints.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950547919
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49046/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953785181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952519237
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49105/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953735584
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49176/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952475000
**[Test build #144635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144635/testReport)** for PR 34375 at commit [`c3b32bd`](https://github.com/apache/spark/commit/c3b32bdd7d2a79bf4d90ea795fcbd95f86f2fb41).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953744683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950527921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144575/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952496712
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144635/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953686824
**[Test build #144707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144707/testReport)** for PR 34375 at commit [`6e0fdec`](https://github.com/apache/spark/commit/6e0fdecba955e0c68954c3bf02d16cb45c408c8a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SparkJobInfo(NamedTuple):`
* `class SparkStageInfo(NamedTuple):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953744683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952516488
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49105/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950511723
**[Test build #144575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144575/testReport)** for PR 34375 at commit [`e8de4ac`](https://github.com/apache/spark/commit/e8de4ac8f3d77455fae6b273e1076fa002ac3169).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on a change in pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r736427091
##########
File path: python/pyspark/status.py
##########
@@ -19,6 +19,10 @@
__all__ = ["SparkJobInfo", "SparkStageInfo", "StatusTracker"]
+from typing import Optional, List
+
+from py4j.java_gateway import JavaObject
Review comment:
Thanks for your review, @zero323 ! Can you explain more? dev/lint-python has passed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952496427
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49105/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953707455
**[Test build #144711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144711/testReport)** for PR 34375 at commit [`59ed04c`](https://github.com/apache/spark/commit/59ed04c6cca4cfc5f372e137bd9bf8b84940506d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-954432956
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950554992
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49046/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950554992
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49046/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950524514
**[Test build #144575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144575/testReport)** for PR 34375 at commit [`e8de4ac`](https://github.com/apache/spark/commit/e8de4ac8f3d77455fae6b273e1076fa002ac3169).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952519237
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49105/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r738143060
##########
File path: python/pyspark/status.pyi
##########
@@ -1,42 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from typing import List, NamedTuple, Optional
-from py4j.java_gateway import JavaArray, JavaObject # type: ignore[import]
-
-class SparkJobInfo(NamedTuple):
- jobId: int
- stageIds: JavaArray
- status: str
-
-class SparkStageInfo(NamedTuple):
- stageId: int
- currentAttemptId: int
- name: str
- numTasks: int
- numActiveTasks: int
- numCompletedTasks: int
- numFailedTasks: int
Review comment:
These two are still missing from annotated results. Please see #34228 for the convention we use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34375:
URL: https://github.com/apache/spark/pull/34375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950527921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144575/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950511723
**[Test build #144575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144575/testReport)** for PR 34375 at commit [`e8de4ac`](https://github.com/apache/spark/commit/e8de4ac8f3d77455fae6b273e1076fa002ac3169).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953696035
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49176/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952475000
**[Test build #144635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144635/testReport)** for PR 34375 at commit [`c3b32bd`](https://github.com/apache/spark/commit/c3b32bdd7d2a79bf4d90ea795fcbd95f86f2fb41).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953744664
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952487989
**[Test build #144635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144635/testReport)** for PR 34375 at commit [`c3b32bd`](https://github.com/apache/spark/commit/c3b32bdd7d2a79bf4d90ea795fcbd95f86f2fb41).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-952496712
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144635/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953663187
**[Test build #144707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144707/testReport)** for PR 34375 at commit [`6e0fdec`](https://github.com/apache/spark/commit/6e0fdecba955e0c68954c3bf02d16cb45c408c8a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953705222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144707/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-951738015
ping @zero323 too 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950717958
ping @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953705222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144707/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r738197105
##########
File path: python/pyspark/status.py
##########
@@ -15,23 +15,34 @@
# limitations under the License.
#
-from collections import namedtuple
-
__all__ = ["SparkJobInfo", "SparkStageInfo", "StatusTracker"]
+from typing import Optional, List, NamedTuple
Review comment:
Nit. It would be better if these were in lexicographic order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on a change in pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r737041967
##########
File path: python/pyspark/status.py
##########
@@ -19,6 +19,10 @@
__all__ = ["SparkJobInfo", "SparkStageInfo", "StatusTracker"]
+from typing import Optional, List
+
+from py4j.java_gateway import JavaObject
Review comment:
Thanks for your information, @zero323 . I will pay attention! Should I create a jira ticket to remove [ignore_imports of py4j](https://github.com/apache/spark/blob/6d3cfed0e8ab2812bc44bfcd5b82d8d227e77a29/python/mypy.ini#L116-L117) ? And please take a look in this PR when you have time. Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953727571
**[Test build #144711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144711/testReport)** for PR 34375 at commit [`59ed04c`](https://github.com/apache/spark/commit/59ed04c6cca4cfc5f372e137bd9bf8b84940506d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953773860
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-954443101
thanks! @HyukjinKwon @zero323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-950528353
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49046/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953663187
**[Test build #144707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144707/testReport)** for PR 34375 at commit [`6e0fdec`](https://github.com/apache/spark/commit/6e0fdecba955e0c68954c3bf02d16cb45c408c8a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953707455
**[Test build #144711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144711/testReport)** for PR 34375 at commit [`59ed04c`](https://github.com/apache/spark/commit/59ed04c6cca4cfc5f372e137bd9bf8b84940506d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r736454891
##########
File path: python/pyspark/status.py
##########
@@ -19,6 +19,10 @@
__all__ = ["SparkJobInfo", "SparkStageInfo", "StatusTracker"]
+from typing import Optional, List
+
+from py4j.java_gateway import JavaObject
Review comment:
To indicate, that we don't expect this stuff to typecheck at all.
This stays in contrast to other libraries we use, that might or might not type check depending on the version and / or availability of the 3rd party type hints (and, possibly, plugins)
> dev/lint-python has passed.
`dev/lint-python` should pass, because we this in the configuration
https://github.com/apache/spark/blob/6d3cfed0e8ab2812bc44bfcd5b82d8d227e77a29/python/mypy.ini#L116-L117
That being said, mypy integrity checks can detect only some categories of problems. Data tests can do more, but still depend on having negative test cases in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r736386860
##########
File path: python/pyspark/status.py
##########
@@ -19,6 +19,10 @@
__all__ = ["SparkJobInfo", "SparkStageInfo", "StatusTracker"]
+from typing import Optional, List
+
+from py4j.java_gateway import JavaObject
Review comment:
These should have inline `type: ignore[import]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on a change in pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r738181903
##########
File path: python/pyspark/status.pyi
##########
@@ -1,42 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from typing import List, NamedTuple, Optional
-from py4j.java_gateway import JavaArray, JavaObject # type: ignore[import]
-
-class SparkJobInfo(NamedTuple):
- jobId: int
- stageIds: JavaArray
- status: str
-
-class SparkStageInfo(NamedTuple):
- stageId: int
- currentAttemptId: int
- name: str
- numTasks: int
- numActiveTasks: int
- numCompletedTasks: int
- numFailedTasks: int
Review comment:
Thanks! updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34375: [SPARK-37107][PYTHON] Inline type hints for python/pyspark/status.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34375:
URL: https://github.com/apache/spark/pull/34375#issuecomment-953785181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org