You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sandip-db (via GitHub)" <gi...@apache.org> on 2024/02/02 08:25:26 UTC
[PR] [SPARK-46954][SQL] XML: Optimize schema index lookup [spark]
sandip-db opened a new pull request, #44997:
URL: https://github.com/apache/spark/pull/44997
### What changes were proposed in this pull request?
Optimize schema field index lookup in the XML parser
### Why are the changes needed?
10%-15% Perf improvement
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing unit tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46954][SQL] XML: Optimize schema index lookup [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44997:
URL: https://github.com/apache/spark/pull/44997#discussion_r1477695657
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala:
##########
@@ -315,6 +317,10 @@ case class StructType(fields: Array[StructField]) extends DataType with Seq[Stru
nameToIndex.get(name)
}
+ def getFieldIndexCaseInsensitive(name: String): Option[Int] = {
Review Comment:
Let's don't add this as an API tho.
```suggestion
private[sql] def getFieldIndexCaseInsensitive(name: String): Option[Int] = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46954][SQL] XML: Optimize schema index lookup [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44997: [SPARK-46954][SQL] XML: Optimize schema index lookup
URL: https://github.com/apache/spark/pull/44997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46954][SQL] XML: Optimize schema index lookup [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44997:
URL: https://github.com/apache/spark/pull/44997#issuecomment-1926274535
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org