[GitHub] [pulsar] sijie commented on a change in pull request #4502: [Issue 4480] Support setting zk chroot path when initialize cluster metadata

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #4502: [Issue 4480] Support setting zk chroot path when initialize cluster metadata
URL: https://github.com/apache/pulsar/pull/4502#discussion_r292252426
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
 ##########
 @@ -273,6 +270,29 @@ public static void main(String[] args) throws Exception {
         log.info("Cluster metadata for '{}' setup correctly", arguments.cluster);
     }
 
+    private static ZooKeeper initZk(String connection, int sessionTimeout) throws Exception {
 
 Review comment:
   @murong00 can you rewrite unit tests for this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services