[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2820: FINERACT-1838: Loan account external events with repayment schedule

[GitBox <gi...@apache.org>]

josehernandezfintecheandomx commented on code in PR #2820:
URL: https://github.com/apache/fineract/pull/2820#discussion_r1050949393


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanBusinessEventSerializer.java:
##########
@@ -46,6 +48,9 @@ public <T> boolean canSerialize(BusinessEvent<T> event) {
     protected <T> ByteBufferSerializable toAvroDTO(BusinessEvent<T> rawEvent) {
         LoanBusinessEvent event = (LoanBusinessEvent) rawEvent;
         LoanAccountData data = service.retrieveOne(event.get().getId());
+        if (event instanceof LoanApprovedBusinessEvent || event instanceof LoanDisbursalBusinessEvent) {

Review Comment:
   Done, It was set for every LoanBusinessEvent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org