You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by "Oleg Kalnichevski (Jira)" <ji...@apache.org> on 2019/11/26 10:56:00 UTC

[jira] [Resolved] (HTTPCLIENT-2030) PublicSuffixMatcher::getDomainRoot with expectation fails on invalid domain names.

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-2030.
-------------------------------------------
    Fix Version/s: 5.0 Beta7
       Resolution: Fixed

Merged to master.

Oleg

> PublicSuffixMatcher::getDomainRoot with expectation fails on invalid domain names.
> ----------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2030
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2030
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Priority: Major
>             Fix For: 5.0 Beta7
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Assume 
>     PublicSuffixMatcher matcher = PublicSuffixMatcherLoader.getDefault();
>  Then this 
>      matcher.getDomainRoot("www.example.unknown")
>  returns 
>     "unknown"
>  which is correct because no expectation was given about the domain name.
> However when I do set a required expectation with something like
>     matcher.getDomainRoot("www.example.unknown", DomainType.ICANN)
>  then the current implementation still returns 
>    "unknown"
>  instead of the expected 
>    null
>  indicating that there was no match.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org