You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/03/10 18:14:07 UTC
Review Request 44635: Corrected the log message and variable name in
executor library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
Diff: https://reviews.apache.org/r/44635/diff/
Testing
-------
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
Re: Review Request 44635: Corrected the log message and variable name
in executor library.
Posted by Ben Mahler <be...@gmail.com>.
> On March 15, 2016, 3:13 a.m., Ben Mahler wrote:
> > Just a minor tweak that I'll apply.
We refer to this as the executor driver rather than the executor library, I'll use the following commit message:
Minor environment variable parsing cleanup in executor driver.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/#review123584
-----------------------------------------------------------
On March 14, 2016, 5:45 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44635/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
>
> Diff: https://reviews.apache.org/r/44635/diff/
>
>
> Testing
> -------
>
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 44635: Corrected the log message and variable name
in executor library.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/#review123584
-----------------------------------------------------------
Fix it, then Ship it!
Just a minor tweak that I'll apply.
src/exec/exec.cpp (lines 712 - 713)
<https://reviews.apache.org/r/44635/#comment185810>
We tend to put the space on the next line, and I think having the "of" on the next line is clearer here, so:
```
EXIT(EXIT_FAILURE)
<< "Failed to parse value '" << value.get() << "'"
<< " of 'MESOS_RECOVERY_TIMEOUT': " << parse.error();
```
- Ben Mahler
On March 14, 2016, 5:45 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44635/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
>
> Diff: https://reviews.apache.org/r/44635/diff/
>
>
> Testing
> -------
>
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 44635: Corrected the log message and variable name
in executor library.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/
-----------------------------------------------------------
(Updated March 14, 2016, 5:45 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
Diff: https://reviews.apache.org/r/44635/diff/
Testing
-------
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
Re: Review Request 44635: Corrected the log message and variable name
in executor library.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/
-----------------------------------------------------------
(Updated March 11, 2016, 4 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
Diff: https://reviews.apache.org/r/44635/diff/
Testing
-------
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov