You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Venky Iyer (JIRA)" <ji...@apache.org> on 2009/11/06 23:12:32 UTC

[jira] Created: (HIVE-916) typedbytes: changes

typedbytes: changes
-------------------

                 Key: HIVE-916
                 URL: https://issues.apache.org/jira/browse/HIVE-916
             Project: Hadoop Hive
          Issue Type: Bug
            Reporter: Venky Iyer
            Assignee: Namit Jain


1.  probably use int for tinyint/shortint instead of bytes
2. pick different typecode for eo-record marker: not 100/101/255
3. use string when type not specified in AS clause

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-916) typedbytes: changes

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795479#action_12795479 ] 

He Yongqiang commented on HIVE-916:
-----------------------------------

+1, running tests now.

> typedbytes: changes
> -------------------
>
>                 Key: HIVE-916
>                 URL: https://issues.apache.org/jira/browse/HIVE-916
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Venky Iyer
>            Assignee: Namit Jain
>             Fix For: 0.5.0
>
>         Attachments: hive.916.1.patch
>
>
> 1.  probably use int for tinyint/shortint instead of bytes
> 2. pick different typecode for eo-record marker: not 100/101/255
> 3. use string when type not specified in AS clause

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-916) typedbytes: changes

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795398#action_12795398 ] 

Namit Jain commented on HIVE-916:
---------------------------------

Also for 1., we use a short for tinyint

FROM (
  FROM src
  SELECT TRANSFORM(cast(src.key as smallint), src.value) ROW FORMAT SERDE 'org.apache.hadoop.hive.contrib.serde2.TypedBytesSerDe'
  RECORDWRITER 'org.apache.hadoop.hive.contrib.util.typedbytes.TypedBytesRecordWriter'
  USING '/bin/cat'
  AS (tkey smallint, tvalue string) ROW FORMAT SERDE 'org.apache.hadoop.hive.contrib.serde2.TypedBytesSerDe'
  RECORDREADER 'org.apache.hadoop.hive.contrib.util.typedbytes.TypedBytesRecordReader'
) tmap
INSERT OVERWRITE TABLE dest1 SELECT tkey, tvalue;

> typedbytes: changes
> -------------------
>
>                 Key: HIVE-916
>                 URL: https://issues.apache.org/jira/browse/HIVE-916
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Venky Iyer
>            Assignee: Namit Jain
>
> 1.  probably use int for tinyint/shortint instead of bytes
> 2. pick different typecode for eo-record marker: not 100/101/255
> 3. use string when type not specified in AS clause

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-916) typedbytes: changes

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-916:
----------------------------

    Attachment: hive.916.1.patch

> typedbytes: changes
> -------------------
>
>                 Key: HIVE-916
>                 URL: https://issues.apache.org/jira/browse/HIVE-916
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Venky Iyer
>            Assignee: Namit Jain
>             Fix For: 0.5.0
>
>         Attachments: hive.916.1.patch
>
>
> 1.  probably use int for tinyint/shortint instead of bytes
> 2. pick different typecode for eo-record marker: not 100/101/255
> 3. use string when type not specified in AS clause

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-916) typedbytes: changes

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-916:
------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks Namit!

> typedbytes: changes
> -------------------
>
>                 Key: HIVE-916
>                 URL: https://issues.apache.org/jira/browse/HIVE-916
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Venky Iyer
>            Assignee: Namit Jain
>             Fix For: 0.5.0
>
>         Attachments: hive.916.1.patch
>
>
> 1.  probably use int for tinyint/shortint instead of bytes
> 2. pick different typecode for eo-record marker: not 100/101/255
> 3. use string when type not specified in AS clause

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-916) typedbytes: changes

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-916:
----------------------------

    Fix Version/s: 0.5.0
           Status: Patch Available  (was: Open)

> typedbytes: changes
> -------------------
>
>                 Key: HIVE-916
>                 URL: https://issues.apache.org/jira/browse/HIVE-916
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Venky Iyer
>            Assignee: Namit Jain
>             Fix For: 0.5.0
>
>         Attachments: hive.916.1.patch
>
>
> 1.  probably use int for tinyint/shortint instead of bytes
> 2. pick different typecode for eo-record marker: not 100/101/255
> 3. use string when type not specified in AS clause

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-916) typedbytes: changes

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795397#action_12795397 ] 

Namit Jain commented on HIVE-916:
---------------------------------

For 3., the following test works:

FROM (
  FROM src
  SELECT TRANSFORM(src.key, src.value) ROW FORMAT SERDE 'org.apache.hadoop.hive.contrib.serde2.TypedBytesSerDe'
  RECORDWRITER 'org.apache.hadoop.hive.contrib.util.typedbytes.TypedBytesRecordWriter'
  USING '/bin/cat'
  AS (tkey, tvalue) ROW FORMAT SERDE 'org.apache.hadoop.hive.contrib.serde2.TypedBytesSerDe'
  RECORDREADER 'org.apache.hadoop.hive.contrib.util.typedbytes.TypedBytesRecordReader'
) tmap
INSERT OVERWRITE TABLE dest1 SELECT tkey, tvalue;


The output type is interpreted as string - what is missing ?

> typedbytes: changes
> -------------------
>
>                 Key: HIVE-916
>                 URL: https://issues.apache.org/jira/browse/HIVE-916
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Venky Iyer
>            Assignee: Namit Jain
>
> 1.  probably use int for tinyint/shortint instead of bytes
> 2. pick different typecode for eo-record marker: not 100/101/255
> 3. use string when type not specified in AS clause

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.