[GitHub] spark pull request #13720: [SPARK-16004] [SQL] improve the display of Catalo...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13720#discussion_r67811340
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ---
    @@ -180,7 +180,8 @@ case class CatalogTable(
           Seq(s"Table: ${identifier.quotedString}",
             if (owner.nonEmpty) s"Owner: $owner" else "",
             s"Created: ${new Date(createTime).toString}",
    -        s"Last Access: ${new Date(lastAccessTime).toString}",
    +        "Last Access: " +
    +          (if (lastAccessTime == -1) "UNKNOWN" else new Date(lastAccessTime).toString),
    --- End diff --
    
    I don't feel strongly about it, but seems like elsewhere an empty string is used for no values. This seems slightly preferable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org