[jira] [Updated] (THRIFT-2969) nodejs: DRY up library tests

["Andrew de Andrade (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew de Andrade updated THRIFT-2969:
--------------------------------------
    Attachment: 0008-Add-nodejs-type-to-the-cross-tests.-tcp-only-for-now.patch

I just realized that I need to update the test/test.sh file to include the --type parameter that now needs to be passed to both lib/nodejs/test/client.js and lib/nodejs/test/server.js. Here is a patch for that. I have only added the tcp type, but other types can be enabled in the cross test by changing the value of the nodejs_types variable.

> nodejs: DRY up library tests
> ----------------------------
>
>                 Key: THRIFT-2969
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2969
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>            Reporter: Andrew de Andrade
>         Attachments: 0001-Consolidated-nodejs-server-client-test-code.patch, 0002-DRY-up-nodejs-test-drivers.patch, 0003-DRY-up-nodejs-test-handlers.patch, 0004-DRY-nodejs-handlers-more.patch, 0005-Clean-up-test-driver-code-some-more.patch, 0006-Dry-up-nodejs-testAll.sh.-Cover-all-configurations.patch, 0007-nodejs-include-websockets-in-for-each-testAll.sh-loo.patch, 0008-Add-nodejs-type-to-the-cross-tests.-tcp-only-for-now.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)