[GitHub] reminisce commented on a change in pull request #10940: Fused LSTM Cell

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #10940: Fused LSTM Cell
URL: https://github.com/apache/incubator-mxnet/pull/10940#discussion_r188114250
 
 

 ##########
 File path: src/operator/tensor/matrix_op-inl.h
 ##########
 @@ -152,18 +152,31 @@ inline TShape InferReshapeShape(const nnvm::Tuple<IType>& shape,
 }
 
 inline bool ReshapeShape(const nnvm::NodeAttrs& attrs,
-                             std::vector<TShape> *in_attrs,
-                             std::vector<TShape> *out_attrs) {
+                         std::vector<TShape> *in_attrs,
+                         std::vector<TShape> *out_attrs) {
   const ReshapeParam& param_ = nnvm::get<ReshapeParam>(attrs.parsed);
   CHECK_EQ(in_attrs->size(), 1U) << "Input: [data]";
   CHECK_EQ(out_attrs->size(), 1U);
-  const TShape &dshape = (*in_attrs)[0];
+  TShape &dshape = (*in_attrs)[0];
   if (dshape.ndim() == 0) return false;
   TShape oshape;
   if (param_.shape.ndim() != 0) {
     oshape = InferReshapeShape(param_.shape, dshape, param_.reverse);
+    int num_zeros = 0;
 
 Review comment:
   Add a comment here describing why this is needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services