You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lucky-chen <gi...@git.apache.org> on 2018/06/05 03:24:18 UTC

[GitHub] incubator-weex pull request #1241: [WEEX-436] [iOS] fix history issue : dele...

GitHub user lucky-chen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1241

    [WEEX-436] [iOS] fix history issue : delete rootNode in mainThread

    fix history issue : delete rootNode in mainThread
    
    in some case ,`WXComponentManager dealloc` execute in mainThread 
    but all node operation(new / add / delete/other) should be in ComponentThread


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucky-chen/incubator-weex ios-bugfix-parentnode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1241
    
----
commit aded238200ffc98917217a84b30d6c5bc89f25db
Author: zhongcang <qh...@...>
Date:   2018-06-05T03:17:48Z

    * [iOS] fix history issue : delete rootNode in mainThread

----


---

[GitHub] incubator-weex pull request #1241: [WEEX-436] [iOS] fix history issue : dele...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1241


---

[GitHub] incubator-weex issue #1241: [WEEX-436] [iOS] fix history issue : delete root...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1241
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---