You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/23 13:22:20 UTC

[GitHub] [skywalking] wu-sheng opened a new pull request #4402: Officially add LUA agent link in the main repo and document.

wu-sheng opened a new pull request #4402: Officially add LUA agent link in the main repo and document.
URL: https://github.com/apache/skywalking/pull/4402
 
 
   Due to the local tests have passed, I officially add the link of Lua agent repo to the main project. Let's make this as a part of 7.0.0 :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm commented on a change in pull request #4402: Officially add LUA agent link in the main repo and document.

Posted by GitBox <gi...@apache.org>.
aderm commented on a change in pull request #4402: Officially add LUA agent link in the main repo and document.
URL: https://github.com/apache/skywalking/pull/4402#discussion_r383004668
 
 

 ##########
 File path: README.md
 ##########
 @@ -35,9 +35,10 @@ SkyWalking supports to collect telemetry (traces and metrics) data from multiple
 and multiple formats,
 including
 1. Java, [.NET Core](https://github.com/SkyAPM/SkyAPM-dotnet), [NodeJS](https://github.com/SkyAPM/SkyAPM-nodejs) and [PHP](https://github.com/SkyAPM/SkyAPM-php-sdk) auto-instrument agents in SkyWalking format
-1. Manual-instrument [Go agent](https://github.com/tetratelabs/go2sky) in SkyWalking format.
-1. Istio telemetry format
-1. Envoy gRPC Access Log Service (ALS) format in Istio controlled service mesh
+1. [Go agent](https://github.com/tetratelabs/go2sky).
+1. [LUA agent](https://github.com/apache/skywalking-nginx-lua), especially for Nginx, OpenResty.
+1. Envoy gRPC Access Log Service (ALS) format in Istio controlled service mesh. 
 
 Review comment:
   ```suggestion
   1. Envoy gRPC Access Log Service (ALS) format in Istio controlled by service mesh. 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4402: Officially add LUA agent link in the main repo and document.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4402: Officially add LUA agent link in the main repo and document.
URL: https://github.com/apache/skywalking/pull/4402#issuecomment-590072598
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4402?src=pr&el=h1) Report
   > Merging [#4402](https://codecov.io/gh/apache/skywalking/pull/4402?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2ac2d2555ad46f890d46897caa3ca5dea248f52b?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4402/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4402?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4402   +/-   ##
   =======================================
     Coverage   25.55%   25.55%           
   =======================================
     Files        1209     1209           
     Lines       27914    27914           
     Branches     3851     3851           
   =======================================
     Hits         7134     7134           
     Misses      20129    20129           
     Partials      651      651
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4402?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4402?src=pr&el=footer). Last update [2ac2d25...ee5c8cc](https://codecov.io/gh/apache/skywalking/pull/4402?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm merged pull request #4402: Officially add LUA agent link in the main repo and document.

Posted by GitBox <gi...@apache.org>.
aderm merged pull request #4402: Officially add LUA agent link in the main repo and document.
URL: https://github.com/apache/skywalking/pull/4402
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] aderm commented on a change in pull request #4402: Officially add LUA agent link in the main repo and document.

Posted by GitBox <gi...@apache.org>.
aderm commented on a change in pull request #4402: Officially add LUA agent link in the main repo and document.
URL: https://github.com/apache/skywalking/pull/4402#discussion_r383005938
 
 

 ##########
 File path: README.md
 ##########
 @@ -35,9 +35,10 @@ SkyWalking supports to collect telemetry (traces and metrics) data from multiple
 and multiple formats,
 including
 1. Java, [.NET Core](https://github.com/SkyAPM/SkyAPM-dotnet), [NodeJS](https://github.com/SkyAPM/SkyAPM-nodejs) and [PHP](https://github.com/SkyAPM/SkyAPM-php-sdk) auto-instrument agents in SkyWalking format
-1. Manual-instrument [Go agent](https://github.com/tetratelabs/go2sky) in SkyWalking format.
-1. Istio telemetry format
-1. Envoy gRPC Access Log Service (ALS) format in Istio controlled service mesh
+1. [Go agent](https://github.com/tetratelabs/go2sky).
+1. [LUA agent](https://github.com/apache/skywalking-nginx-lua), especially for Nginx, OpenResty.
+1. Envoy gRPC Access Log Service (ALS) format in Istio controlled service mesh. 
 
 Review comment:
    ok, i understand it wrong

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4402: Officially add LUA agent link in the main repo and document.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4402: Officially add LUA agent link in the main repo and document.
URL: https://github.com/apache/skywalking/pull/4402#discussion_r383004974
 
 

 ##########
 File path: README.md
 ##########
 @@ -35,9 +35,10 @@ SkyWalking supports to collect telemetry (traces and metrics) data from multiple
 and multiple formats,
 including
 1. Java, [.NET Core](https://github.com/SkyAPM/SkyAPM-dotnet), [NodeJS](https://github.com/SkyAPM/SkyAPM-nodejs) and [PHP](https://github.com/SkyAPM/SkyAPM-php-sdk) auto-instrument agents in SkyWalking format
-1. Manual-instrument [Go agent](https://github.com/tetratelabs/go2sky) in SkyWalking format.
-1. Istio telemetry format
-1. Envoy gRPC Access Log Service (ALS) format in Istio controlled service mesh
+1. [Go agent](https://github.com/tetratelabs/go2sky).
+1. [LUA agent](https://github.com/apache/skywalking-nginx-lua), especially for Nginx, OpenResty.
+1. Envoy gRPC Access Log Service (ALS) format in Istio controlled service mesh. 
 
 Review comment:
   There is no `by` here. Istio is the control panel.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services