[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10529: Remove v prefix in image tags published to Docker Hub

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on code in PR #10529:
URL: https://github.com/apache/skywalking/pull/10529#discussion_r1133252020


##########
.github/workflows/publish-docker.yaml:
##########
@@ -73,10 +74,10 @@ jobs:
         uses: docker/setup-qemu-action@v1
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v1
-      - name: Build and push docker images
-        run: make build.all docker.push
       - name: Build and push docker images based on Java 17
         env:
           SW_OAP_BASE_IMAGE: eclipse-temurin:17-jre
           TAG: ${{ env.TAG }}-java17
         run: make build.all docker.push
+      - name: Build and push docker images
+        run: make build.all docker.push

Review Comment:
   I swap this so the `latest` tag will remain for `java11` and `9.4.0-java-17` for java 17



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org