You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 13:21:20 UTC

[GitHub] [spark] dengziming commented on a diff in pull request #38638: [SPARK-41122][CONNECT] Explain API can support different modes

dengziming commented on code in PR #38638:
URL: https://github.com/apache/spark/pull/38638#discussion_r1021527911


##########
connector/connect/src/main/protobuf/spark/connect/base.proto:
##########
@@ -38,6 +38,30 @@ message Plan {
   }
 }
 
+// Plan explanation mode.
+enum ExplainMode {
+  MODE_UNSPECIFIED = 0;
+
+  // Generates only physical plan.
+  SIMPLE = 1;
+
+  // Generates parsed logical plan, analyzed logical plan, optimized logical plan and physical plan.
+  // Parsed Logical plan is a unresolved plan that extracted from the query. Analyzed logical plans
+  // transforms which translates unresolvedAttribute and unresolvedRelation into fully typed objects.
+  // The optimized logical plan transforms through a set of optimization rules, resulting in the
+  // physical plan.
+  EXTENDED = 2;
+
+  //Generates code for the statement, if any and a physical plan.

Review Comment:
   nit: space after "//"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org