[GitHub] [james-project] ouvtam commented on pull request #1290: [JAMES-3841] ActiveMQ: replace simple connection health check with re…

[GitBox <gi...@apache.org>]

ouvtam commented on PR #1290:
URL: https://github.com/apache/james-project/pull/1290#issuecomment-1301724865

   It depends what health means. For instance, is ActiveMQ healthy when you can initiate a connection (old behaviour), but ActiveMQ reached a limit (memory, store, temp)?
   
   In short, health before:
   - Can connect to ActiveMQ
   
   Health after this PR:
   - Can connect to ActiveMQ
   - Can send a message
   - Receive a response in a specific timeout (currently 1s)
   Furthermore, health check could be improved by checking the stats (e.g. tempPercentUsage < 90%, storePercentUsage < 90%, memoryPercentUsage < 90%).
   
   Another option would be to separate collecting statistics and health check. However, the health check could access the information in the stats to determine if healthy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org