You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "robertoschwald (via GitHub)" <gi...@apache.org> on 2025/05/19 08:04:46 UTC
[PR] Test-Case for #14753 [grails-core]
robertoschwald opened a new pull request, #14755:
URL: https://github.com/apache/grails-core/pull/14755
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "robertoschwald (via GitHub)" <gi...@apache.org>.
robertoschwald commented on PR #14755:
URL: https://github.com/apache/grails-core/pull/14755#issuecomment-2891090056
The problem with bundle ordering materalized here when adding a PluginAwareResourceBundleMessageSource messageSource definition and sets own basenames to be able to overwrite other bundles keys in a centralized bundle file. Then the plugin basenames were first in the list, not last.
So yes, the test should work against 7.0.0, but also with #14753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #14755:
URL: https://github.com/apache/grails-core/pull/14755#issuecomment-2890485080
OK, but when I run the test added in this PR, with branch `7.0.x` checked out, it succeeds.
I would expect it to fail before #14753 is merged.
It makes me wonder if the test validates what it's suppose to validate.
It's likely I'm missing something so I just want to hear if this is expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #14755:
URL: https://github.com/apache/grails-core/pull/14755#issuecomment-3198603098
@jdaugherty Agreed. I merged to two newest PRs together as a starting point, since it was disjointed and hard to follow across the set of PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #14755:
URL: https://github.com/apache/grails-core/pull/14755#issuecomment-2890340264
Is this test supposed to fail before #11795 is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14755:
URL: https://github.com/apache/grails-core/pull/14755#issuecomment-2891403699
Can we add a test for the problem that this fixes? to show it fails in 7 prior to the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "robertoschwald (via GitHub)" <gi...@apache.org>.
robertoschwald commented on PR #14755:
URL: https://github.com/apache/grails-core/pull/14755#issuecomment-2890396019
This PRs base branch is [apache:issue-11795](https://github.com/apache/grails-core/tree/issue-11795), the base for PR #14753
@jdaugherty rebased my original PR into a new one I cannot push to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14755:
URL: https://github.com/apache/grails-core/pull/14755#issuecomment-3198584999
@jamesfredley I don't think this should have been merged. We needed a test case that showed this was broken prior to the fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test-Case for #14753 [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #14755:
URL: https://github.com/apache/grails-core/pull/14755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org